If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

browser_all_files_referenced.js should be able to handle template strings

RESOLVED FIXED in Firefox 55

Status

()

Firefox
General
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

53 Branch
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 months ago
I'm trying to add some code that references a frame script via a template string.

At the moment, browser_all_files_referenced.js says the frame script is undefined as it doesn't understand about template strings.

I've got a patch that allows it to understand template strings, and makes it more flexible for stripping the query from the url (if there is one).
(Assignee)

Comment 1

4 months ago
Created attachment 8874807 [details] [diff] [review]
Adds template string support
Attachment #8874807 - Flags: review?(florian)
Comment on attachment 8874807 [details] [diff] [review]
Adds template string support

Review of attachment 8874807 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if it's green on try. Thanks for documenting the --appname dist trick :-).

::: browser/base/content/test/static/browser_all_files_referenced.js
@@ -324,4 @@
>      let baseUri;
>      for (let line of data.split("\n")) {
>        let urls =
> -        line.match(/["']chrome:\/\/[a-zA-Z0-9 -]+\/(content|skin|locale)\/[^"' ]*["']/g);

I think you want to exclude the ` character too in this part of the regexp: [^"' ]
Attachment #8874807 - Flags: review?(florian) → review+
(Assignee)

Comment 3

4 months ago
Created attachment 8874828 [details] [diff] [review]
Adds template string support v2

Updated patch, try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f1345aeebcad23a804c5c7fc09ada9404178384
Attachment #8874807 - Attachment is obsolete: true
Attachment #8874828 - Flags: review+

Comment 4

4 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1409f1a455c
browser_all_files_referenced.js should be able to handle template strings. r=florian

Comment 5

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e1409f1a455c
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.