Closed Bug 1370519 Opened 3 years ago Closed 3 years ago

Remove child side object abstraction from File Handle implementation

Categories

(Core :: Storage: IndexedDB, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(4 files)

It seems the API won't be re-used by other storage APIs (besides IndexedDB) so we can remove the abstraction. This will help to easily fix bug 1366647.

Patches are currently on try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f88f93ff922df09be129e35e1217a669646d6cef&selectedJob=104819918
Blocks: 1366647
Priority: -- → P2
Assignee: nobody → jvarga
Attachment #8875147 - Flags: review?(btseng)
Attachment #8875154 - Flags: review?(btseng)
Attachment #8875156 - Flags: review?(btseng)
Attachment #8875147 - Attachment is patch: true
Comment on attachment 8875151 [details] [diff] [review]
Part 2: Merge FileHandle base classes with IndexedDB specific classes (except parent actors)

Review of attachment 8875151 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for merging these stuff!

::: dom/indexedDB/IDBMutableFile.h
@@ +111,5 @@
> +  bool
> +  IsInvalidated() const
> +  {
> +    AssertIsOnOwningThread();
> + 

nit: remove space.
Attachment #8875151 - Flags: review?(btseng) → review+
Attachment #8875147 - Flags: review?(btseng) → review+
Attachment #8875154 - Flags: review?(btseng) → review+
Attachment #8875156 - Flags: review?(btseng) → review+
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1637d5c1dd6c
Part 1: Add missing includes to fix non-unified builds; r=btseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/398e771204b7
Part 2: Merge FileHandle base classes with IndexedDB specific classes (except parent actors); r=btseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f90f396476
Part 3: Remove unused files; r=btseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/50f39d5543d8
Part 4: Get rid of FileHandleCommon.h/cpp; r=btseng
You need to log in before you can comment on or make changes to this bug.