Closed Bug 1370541 Opened 2 years ago Closed 2 years ago

Add more assertions that function name atom is marked

Categories

(Core :: JavaScript: GC, defect)

55 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Bug 1367727 is showing some crashes related to JSFunction::atom_.  This is a patch to assert that this atom is always marked correctly when it's set.

This didn't show up anything on try but still might help track down the crashes.
Attachment #8874850 - Flags: review?(sphink)
Assignee: nobody → jcoppeard
Comment on attachment 8874850 [details] [diff] [review]
add-function-atom-assertions

Review of attachment 8874850 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed, this patch would have been a lot easier to understand if it were AtomUsedByZone() or something instead, but r=me.
Attachment #8874850 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b675aa9a437
Always assert that the atom is marked when setting a function's name r=sfink
https://hg.mozilla.org/mozilla-central/rev/1b675aa9a437
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.