Closed Bug 1370565 Opened 7 years ago Closed 3 years ago

Wrap histogram storage in a class for access control

Categories

(Toolkit :: Telemetry, enhancement, P4)

Product:
Toolkit
Component:
Telemetry
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: gfritzsche, Unassigned)

References

Details

In bug we are refactoring the histogram storage in TelemetryHistogram.cpp to be much more clear.
However, the implementation there is using globals.

For reasoning about the code (especially multi-threading) it would be helpful to have this wrapped in a class with clear accessor functions (which require locking evidence).

This is probably more feasible after bug 1278821 (otherwise we have locked and unlocked access paths).
Summary: Wrap histogram storage in a class → Wrap histogram storage in a class for access control
Priority: -- → P4
See Also: → 1494243

gfritzsche has not been involved with Mozilla for more than a year so will unfortunately no longer be a suitable mentor.

Mentor: gfritzsche

Chris, do you know if this is still relevant?

Flags: needinfo?(chutten)

It almost certainly will not be, no. Energies are being focused elsewhere (on Glean).

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(chutten)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.