137057 - [modern] tab bar changes height when second tab opened

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[John P Baker]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+)
Gecko/20020410
BuildID:    2002041011

Modern theme.
With a single tab open tab bar is 23px high, when second tab is opened
moves down two pixels to 25px high.

Reproducible: Always
Steps to Reproduce:
Modern theme.
1. preferences don't hide the tab bar when only one tab is open
2. open a second tab
3.

Actual Results:  document window moves down two pixels to make room for higher
tab bar.

Expected Results:  tab bar should stay same height - probably 25px otherwise tab
close
button looks wrongly placed when only one tab is opened.

Comment 1

[John P Baker]

More obvious when you have "Load links in the background" set

Comment 2

[John P Baker]

This would appear to be caused by the close button getting !important
border/padding styles for .toolbarbutton[disabled="true"] when there
is only one tab.

From chrome://global/skin/toolbarbutton.css

Comment 3

[John P Baker]

This is confirmed by adding the following to userChrome.css

.tabs-closebutton[disabled="true"] {
/* bug 137057 */
  margin: 0px 4px !important;
  padding: 4px 2px !important;
  border: none !important;
/* bug 137708 */
  list-style-image: url("chrome://global/skin/icons/close-dis.gif") !important;
}

Comment 4

[Boris Zbarsky [:bzbarsky]]

confirming.  raising severity to major, since this breaks some sites by causing
unwanted onresize events.

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 138524 has been marked as a duplicate of this bug. ***

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 143020 has been marked as a duplicate of this bug. ***

Comment 7

[Andreas Kunz]

What about classic theme?
I can reproduce this with classic, but the summary explicitely mentiones modern.
Is there a separate bug (found none) or should this one be widened?

Comment 8

[John P Baker]

Classic theme WFM 2002050706 - the button has
margin: 3px; padding: 2px; border: 2px;
in both states; So probably not the same bug.

Comment 9

[mental]

*** Bug 145138 has been marked as a duplicate of this bug. ***

Comment 10

[[e-mail]]

Attachment: Propsed patch

This was the best I could do. It also includes the fix to bug 137708.

Comment 11

[Joe Hewitt (gone)]

taking

Comment 12

[Joe Hewitt (gone)]

The patch in bug 137708 fixes this also.

Comment 13

[Alfonso Martinez]

*** Bug 146682 has been marked as a duplicate of this bug. ***

Comment 14

[Brad Garcia]

In comment #4, bzbarsky wrote:

> this breaks some sites by causing unwanted onresize events.

Slightly OT:

If you check the preference for hiding the tab bar when only
one tab is present, then will opening a second tab cause an onresize event?

And if it does, will this also break those sites that you mention?

Comment 15

[Niklas Mehner]

*** Bug 146498 has been marked as a duplicate of this bug. ***

Comment 16

[Boris Zbarsky [:bzbarsky]]

In response to comment 14, yes and yes.  Not much to be done there -- the 
content area _is_ being resized and I see no way to make that not be so in that 
situation.

Comment 17

[Boris Zbarsky [:bzbarsky]]

*** Bug 148146 has been marked as a duplicate of this bug. ***

Comment 18

[Jason Fleshman]

This appears to be fixed now, thanks to the fix for bug 137708, in the trunk
build for 2002-06-01.

Comment 19

[Boris Zbarsky [:bzbarsky]]

Indeed.

Comment 20

[Sander]

*** Bug 171486 has been marked as a duplicate of this bug. ***