Closed
Bug 1370591
Opened 8 years ago
Closed 8 years ago
Remove intent handling code from GeckoProfile
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: droeh, Assigned: droeh)
Details
Attachments
(1 file)
|
4.59 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
We shouldn't really be dealing with the Intent directly in GeckoProfile; instead pass the args string from the Intent and use that.
|
Assignee | |
Comment 1•8 years ago
|
||
Instead of dealing with the intent directly, GeckoProfile stores an intent args string that gets set in BrowserApp.onCreate() and then used in GeckoProfile.get() calls.
Attachment #8882678 -
Flags: review?(snorp)
Comment on attachment 8882678 [details] [diff] [review]
Remove intent handling from GeckoProfile
Review of attachment 8882678 [details] [diff] [review]:
-----------------------------------------------------------------
I assume Gecko hasn't begun to start yet, so this isn't too late?
Attachment #8882678 -
Flags: review?(snorp) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Yeah, I think this is safely before GeckoProfile.get() is called.
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae70aac4b634
Remove intent handling from GeckoProfile. r=snorp
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•