1370605 - [geckoview] Add exitFullScreen() call

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Right now content can enter fullscreen, and the app gets notified, but it cannot exit fullscreen.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1370605 - Don't wait for a resize before entering fullscreen on Android

There may not be a resize event coming, and we don't do anything special
with the transition anyway.

Review commit: https://reviewboard.mozilla.org/r/146290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146290/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1370605 - Add GeckoView.exitFullScreen()

Review commit: https://reviewboard.mozilla.org/r/146292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146292/

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8874916 [details]
Bug 1370605 - Don't wait for a resize before entering fullscreen on Android

https://reviewboard.mozilla.org/r/146290/#review150292

Wasn't this put in place to ensure that content gets the new viewport size when "fullscreenchange" is fired?

Comment 4

[Eugen Sawin [:esawin]]

Comment on attachment 8874917 [details]
Bug 1370605 - Add GeckoView.exitFullScreen()

https://reviewboard.mozilla.org/r/146292/#review150296

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java:612
(Diff revision 1)
>      }
>  
>      /**
> +    * Exits fullscreen mode
> +    */
> +    public void exitFullScreen() {

Fullscreen?

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java:613
(Diff revision 1)
>  
>      /**
> +    * Exits fullscreen mode
> +    */
> +    public void exitFullScreen() {
> +        mEventDispatcher.dispatch("GeckoViewContent:ExitFullScreen", null);

The other events spell it "Fullscreen", better keep it consistent.

::: mobile/android/modules/geckoview/GeckoViewContent.jsm:36
(Diff revision 1)
> +
> +    this.eventDispatcher.registerListener(this, ["GeckoViewContent:ExitFullScreen"]);
> +  }
> +
> +  // Bundle event handler.
> +  onEvent(aEvent, aData, aCallback) {

Please add a general debug log with the event type.

::: mobile/android/modules/geckoview/GeckoViewContent.jsm:39
(Diff revision 1)
> +
> +  // Bundle event handler.
> +  onEvent(aEvent, aData, aCallback) {
> +    switch (aEvent) {
> +      case "GeckoViewContent:ExitFullScreen":
> +        this.browser.messageManager.sendAsyncMessage("GeckoView:DOMFullscreenExited");

All instances of this.browser.messageManager can be refactored to this.messageManager.

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8874916 [details]
Bug 1370605 - Don't wait for a resize before entering fullscreen on Android

https://reviewboard.mozilla.org/r/146290/#review153488

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8874916 [details]
Bug 1370605 - Don't wait for a resize before entering fullscreen on Android

https://reviewboard.mozilla.org/r/146290/#review150292

We'll probably get two resize events now instead of one. We could fix that by keeping the two-stage API, but would need better hooks exposed for GV. Probably worth a followup bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d36177387cb
Don't wait for a resize before entering fullscreen on Android r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/2733d0c87013
Add GeckoView.exitFullScreen() r=esawin

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3d36177387cb
https://hg.mozilla.org/mozilla-central/rev/2733d0c87013