1370634 - Sometimes the firefox.exe process doesn't exit before applying an update.

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Robert Strong (they/them - no direct email)]

A better workaround will be implemented in bug 1112937 but that bug will take a bit longer to implement. One thing that can be done to make this less likely to happen is to extend the wait time for the firefox.exe process so it is more likely to exit.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

It appears that there are times that the firefox.exe process takes longer than normal to exit per bug 1370576. I'd like to get this in for Firefox 55 since I doubt I will be able to land bug 1112937 in time.

Comment 2

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8874983 [details] [diff] [review]
patch rev1

Review of attachment 8874983 [details] [diff] [review]:
-----------------------------------------------------------------

What do you think about bumping this up all the way to the shutdown hang watchdog's timeout (which is 60 + 3 seconds)? Seems like, since both places are trying to define what a reasonable upper bound is for how long a shutdown should take, they should probably be in agreement.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Since these won't ever be exactly in sync I went with 70 seconds. Does that sound ok with you?

Comment 4

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8874999 [details] [diff] [review]
patch rev2

Review of attachment 8874999 [details] [diff] [review]:
-----------------------------------------------------------------

Yep! Thanks.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch with updated comment

I updated the comment so it is clearer.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ccce72b9da0
Make the time to wait the callback application (e.g. firefox.exe) to exit in the updater to be greater than the application's watchdog timer. r=mhowell

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ccce72b9da0