Get rid of ProtoAndIfaceCache::EntrySlotIfExists

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

53 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

The only remaining consumer doesn't really want to use it.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8874974 [details] [diff] [review]
Get rid of ProtoAndIfaceCache::EntrySlotIfExists

Review of attachment 8874974 [details] [diff] [review]:
-----------------------------------------------------------------

You should probably switch your patch in attachment 8874727 [details] [diff] [review] to HasEntryInSlot :-).
Attachment #8874974 - Flags: review?(peterv) → review+
Comment on attachment 8874974 [details] [diff] [review]
Get rid of ProtoAndIfaceCache::EntrySlotIfExists

Review of attachment 8874974 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, we use this in generated code, so how does that work?
Attachment #8874974 - Flags: review+ → review-
It works because this patch is on top of bug 1370614, which replaces all those users (generated, and from attachment 8874727 [details] [diff] [review]) with HasEntryInSlot (and in fact implements it).  See the "depends on" field.  Can I just go with the initial r+?  ;)
Flags: needinfo?(peterv)
Comment on attachment 8874974 [details] [diff] [review]
Get rid of ProtoAndIfaceCache::EntrySlotIfExists

Hmm, ok. It's kind of hard to have to look at dependent bugs when reviewing a patch.
Flags: needinfo?(peterv)
Attachment #8874974 - Flags: review- → review+
Sorry.  I should have made that clearer.  :(
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37f50095e77e
Get rid of ProtoAndIfaceCache::EntrySlotIfExists.  r=peterv
https://hg.mozilla.org/mozilla-central/rev/37f50095e77e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.