Closed Bug 1370663 Opened 3 years ago Closed 3 years ago

linux64 pgo doesn't have talos since May 15th!

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla55

People

(Reporter: jmaher, Assigned: kmoir)

References

Details

Attachments

(1 file, 1 obsolete file)

as seen on dev.platform, we stopped running linux64 pgo talos around May 15th.  I traced this back to bug 1363420, which looks like a revert of another patch:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d27b0fc482eb5a0fb03b243e036abafc081eff15

I am not sure how that caused us to stop running linux64-pgo talos.
:kmoir, could you help me understand the history of bug 1363420 and how the above mentioned patch would turn off linux64pgo talos?
Flags: needinfo?(kmoir)
|if variant == 'stylo ' or 'stylo-sequential'| always evaluates to True. I think the intent was:

  if variant in ('stylo', 'stylo-sequential'):
Attached patch bug1370663.patch (obsolete) — Splinter Review
I had this locally on m-i, I recall writing it but then not pushing because trees were closed and then I forgot to get back to it.  Anyways, gps's suggestion is better 

         # this variant name has branch after the variant type in BBB bug 1338871
-        if variant == 'stylo ' or 'stylo-sequential':
+        if variant == 'stylo ' or variant == 'stylo-sequential':
Flags: needinfo?(kmoir)
Attachment #8875021 - Flags: review?(jmaher)
Attachment #8875021 - Flags: review?(jmaher)
What's with the trailing space in "stylo "? Does that really exist? If so, that feels like a bug.
Attached patch bug1370663.patchSplinter Review
Attachment #8875021 - Attachment is obsolete: true
Attachment #8875023 - Flags: review?(jmaher)
Comment on attachment 8875023 [details] [diff] [review]
bug1370663.patch

Review of attachment 8875023 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for this :kmoir (and :gps)
Attachment #8875023 - Flags: review?(jmaher) → review+
Pushed by kmoir@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a001b6f0364
linux64 pgo doesn't have talos since May 15th! r=jmaher DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/0a001b6f0364
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.