1370700 - nsDOMAttributeMap does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1 - Use mAttributeCache.LookupRemoveIf() to avoid a second hashtable lookup for Remove()

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2 - Use mAttributeCache.GetOrInsert() to avoid a second hashtable lookup for Put()

FYI, bz said in bug 1370632 comment 6:
>mAttributeCache can't contain null values.

Comment 3

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70fd3cba6535779da7e16405058ee831fc3d3a4d

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8875345 [details] [diff] [review]
part 2 - Use mAttributeCache.GetOrInsert() to avoid a second hashtable lookup for Put()

Review of attachment 8875345 [details] [diff] [review]:
-----------------------------------------------------------------

I will trust bz's guidance on this one. ;)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/883902e4d999
part 1 - Use mAttributeCache.LookupRemoveIf() to avoid a second hashtable lookup for Remove().  r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb418afc24af
part 2 - Use mAttributeCache.GetOrInsert() to avoid a second hashtable lookup for Put().  r=froydnj

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/883902e4d999
https://hg.mozilla.org/mozilla-central/rev/eb418afc24af