nsICanvasRenderingContextInternal::SetIsOpaque should return void

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: bytesized, Assigned: bytesized)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

nsICanvasRenderingContextInternal::SetIsOpaque returns nsresult, but no implementations return errors. It should return void.
Priority: -- → P3
Comment hidden (mozreview-request)
Assignee: nobody → ksteuber
Attachment #8876274 - Flags: review?(bzbarsky)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8876274 [details]
Bug 1370727 - Return void from nsICanvasRenderingContextInternal::SetIsOpaque

https://reviewboard.mozilla.org/r/147712/#review152012

::: dom/canvas/WebGLContext.h:385
(Diff revision 1)
>                                nsIInputStream** out_stream) override;
>  
>      virtual already_AddRefed<mozilla::gfx::SourceSurface>
>      GetSurfaceSnapshot(gfxAlphaType* out_alphaType) override;
>  
> -    NS_IMETHOD SetIsOpaque(bool) override { return NS_OK; };
> +    virtual void SetIsOpaque(bool) override { return; };

Just leave the body empty.
Attachment #8876274 - Flags: review?(bzbarsky) → review+
Comment hidden (mozreview-request)

Comment 4

2 years ago
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b713fb1cd98
Return void from nsICanvasRenderingContextInternal::SetIsOpaque r=bz
https://hg.mozilla.org/mozilla-central/rev/5b713fb1cd98
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.