stylo: Make -moz-outline-radius-{*} animatable

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: boris, Assigned: boris)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Updated

a year ago
Summary: stylo: Make -moz-outline-radius-{*} → stylo: Make -moz-outline-radius-{*} animatable
(Assignee)

Updated

a year ago
Assignee: nobody → boris.chiou
(Assignee)

Comment 1

a year ago
Created attachment 8875798 [details]
test case
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8875799 [details]
Bug 1370846 - Make -moz-outline-radius-{*} animatable.

https://reviewboard.mozilla.org/r/147204/#review151536

r=me with dropping the default value of need_clone in impl_corner_style_coord.
And please file a bug that need_clone is not replaced even if animatable.
Attachment #8875799 - Flags: review?(hikezoe) → review+
(Assignee)

Comment 4

a year ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> Comment on attachment 8875799 [details]
> Bug 1370846 - Make -moz-outline-radius-{*} animatable.
> 
> https://reviewboard.mozilla.org/r/147204/#review151536
> 
> r=me with dropping the default value of need_clone in
> impl_corner_style_coord.

OK. I will remove the default value of need_clone in impl_corner_style_style_coord.

> And please file a bug that need_clone is not replaced even if animatable.

OK, I will file a bug to fix this "self.need_clone = need_clone or self.animatable" in data.py. Thanks.
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
Created attachment 8875966 [details] [review]
Servo PR, #17223
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.