Closed
Bug 1370854
Opened 7 years ago
Closed 6 years ago
Adjust page thumbnailer to use all of the top of the page instead of the corner
Categories
(Toolkit :: General, enhancement)
Toolkit
General
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: darktrojan, Unassigned)
Details
Attachments
(2 files, 1 obsolete file)
239.90 KB,
image/png
|
shorlander
:
ui-review-
|
Details |
1.25 KB,
patch
|
mikedeboer
:
feedback+
|
Details | Diff | Splinter Review |
The page thumbnail code currently uses the dimensions of the window displaying the page when calculating what to put in the thumbnail. That is, the thumbnail is of the largest rectangle (at the aspect ratio required) which could fit on the window. I want to change this so that, where possible, any page content below the bottom of the window could also be included. The rectangle is limited only to the width of the window. (If the page is too short then the edge is cut off as currently happens.) In my opinion this produces better looking thumbnails. I have been making the change proposed by means of an extension (New Tab Tools) for a long time, but I can no longer do that with WebExtensions so I propose to move the change into Firefox.
Reporter | ||
Comment 1•7 years ago
|
||
Attachment #8875249 -
Flags: feedback?(mdeboer)
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8875249 [details] [diff] [review] 1370854-1.diff That wasn't the patch I had in mind!
Attachment #8875249 -
Attachment is obsolete: true
Attachment #8875249 -
Flags: feedback?(mdeboer)
Comment 4•7 years ago
|
||
Comment on attachment 8875247 [details]
bitmap.png
Hi Stephen, what do you think of this change to page thumbnails? It looks more accurate to me...
Attachment #8875247 -
Flags: ui-review?(shorlander)
Comment 5•7 years ago
|
||
Comment on attachment 8875254 [details] [diff] [review] 1370854-1.diff Review of attachment 8875254 [details] [diff] [review]: ----------------------------------------------------------------- This change looks good to me, certainly ready for review.
Attachment #8875254 -
Flags: feedback?(mdeboer) → feedback+
Comment 6•7 years ago
|
||
Comment on attachment 8875247 [details] bitmap.png (In reply to Mike de Boer [:mikedeboer] from comment #4) > Comment on attachment 8875247 [details] > bitmap.png > > Hi Stephen, what do you think of this change to page thumbnails? It looks > more accurate to me... The enlarged and cropped thumbnail is a deliberate design decision. Usually the important page defining visuals (e.g. site branding) are located top left. Favoring that area increases the tiles distinctiveness. Also as the thumbnail gets smaller the details get fuzzier making it harder to recognize.
Attachment #8875247 -
Flags: ui-review?(shorlander) → ui-review-
Reporter | ||
Updated•6 years ago
|
Assignee: geoff → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•