1370891 - Render blob images in the thread pool

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Nicolas Silva [:nical]]

We need to get this off the render backend thread at least.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Us the rayon thread pool

This is very naive, there's certainly more efficient ways to dispatch and collect the jobs. I am not 100% certain yet this is correct with respect to how freetype and trheads work together, although the ft libraries are in TLS right now so it might just work. This will most likely become more interesting as we move fonts out of the recording and have to manage what font has been registered on which worker somehow.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8875289 [details] [diff] [review]
Us the rayon thread pool

Review of attachment 8875289 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/src/bindings.rs
@@ +905,5 @@
> +            register_thread_with_profiler(format!("WebRender:Worker#{}", idx));
> +        });
> +
> +    let workers = Arc::new(rayon::ThreadPool::new(worker_config).unwrap());
> +

Can we be reusing the thread pool we already have?

Comment 3

[Nicolas Silva [:nical]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Can we be reusing the thread pool we already have?

Yes that's in the other patch from bug 1370879 (which is written on top of this one).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a61952d96c3f
Render blob images in webrender's thread pool. r=jrmuizel

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a61952d96c3f