Closed
Bug 1370915
Opened 7 years ago
Closed 6 years ago
Crash in java.lang.UnsatisfiedLinkError: at java.lang.Runtime.loadLibrary(Runtime.java)
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Firefox for Android Graveyard
General
Tracking
(fennec+, firefox56 wontfix, firefox57 fixed, firefox58 fixed, firefox59 fixed)
RESOLVED
FIXED
Firefox 59
People
(Reporter: snorp, Assigned: droeh)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
2.37 KB,
patch
|
jchen
:
review+
gchang
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-8fa04c41-a72b-4fa5-bf82-364550170603. ============================================================= This seems to have started when we moved Nightly into the Play Store. Very strange.
Reporter | ||
Comment 1•7 years ago
|
||
The library path in these reports seems wrong. It should consider /data/data/org.mozilla.fennec_aurora/lib, but is not?
Comment 2•7 years ago
|
||
#3 top crash in 57 Beta 9. API's 17-19 are affected. Comments: * why doesn't open firefox on my Android phone. Android version 4.4.0
Hi Snorp, is there something we can do about this top crasher on Beta57? Thanks!
Flags: needinfo?(snorp)
Comment 4•7 years ago
|
||
(In reply to Marcia Knous [:marcia - use ni] from comment #2) > #3 top crash in 57 Beta 9. API's 17-19 are affected. > > Comments: > > * why doesn't open firefox on my Android phone. Android version 4.4.0 It looks as if there is a wider swath of APIs when I looked more recently. It affects from 17-23 now.
Reporter | ||
Comment 5•6 years ago
|
||
I don't see anything else obvious here. Jim, can you take a look?
Flags: needinfo?(snorp) → needinfo?(nchen)
Comment 6•6 years ago
|
||
Most of these are x86 builds running on ARM devices, and a couple cases are ARM builds running on (apparently) ARM64-only devices. Normally in this situation, we would display a message telling the user to reinstall. But bug 1345267 introduced a regression in that behavior, because now we try to load mozglue first, which leads to the crash, before we have a chance to show the message.
Updated•6 years ago
|
status-firefox59:
--- → affected
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → droeh
tracking-fennec: ? → +
Priority: -- → P1
Assignee | ||
Comment 8•6 years ago
|
||
This patch rearranges things so that we always check HardwareUtils.isSupportedSystem() before attempting to load mozglue.
Flags: needinfo?(droeh)
Attachment #8929062 -
Flags: review?(nchen)
Comment 9•6 years ago
|
||
Comment on attachment 8929062 [details] [diff] [review] Only load mozglue on supported hardware Review of attachment 8929062 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java @@ +624,5 @@ > + > + boolean supported = HardwareUtils.isSupportedSystem(); > + if (supported) { > + GeckoLoader.loadMozGlue(appContext); > + supported = supported && GeckoLoader.neonCompatible(); `supported = GeckoLoader.neonCompatible();` ::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java @@ +920,5 @@ > > + boolean supported = HardwareUtils.isSupportedSystem(); > + if (supported) { > + GeckoLoader.loadMozGlue(getApplicationContext()); > + supported = supported && GeckoLoader.neonCompatible(); Same here
Attachment #8929062 -
Flags: review?(nchen) → review+
Comment 10•6 years ago
|
||
Pushed by droeh@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e95bb3b5f38e Reorganize compatibility checks in BrowserApp and GeckoApp to avoid attempting to load mozglue on unsupported hardware. r=jchen
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e95bb3b5f38e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Assignee | ||
Comment 12•6 years ago
|
||
Comment on attachment 8929062 [details] [diff] [review] Only load mozglue on supported hardware Approval Request Comment [Feature/Bug causing the regression]: 1345267 [User impact if declined]: Users who end up with Fennec built for the wrong architecture will crash rather than seeing a message telling them to reinstall. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Low-risk. [Why is the change risky/not risky?]: This just rearranges code to check the architecture before trying to load mozglue. [String changes made/needed]: None
Attachment #8929062 -
Flags: approval-mozilla-release?
Attachment #8929062 -
Flags: approval-mozilla-beta?
Comment 13•6 years ago
|
||
Comment on attachment 8929062 [details] [diff] [review] Only load mozglue on supported hardware Fix a crash. Beta58+.
Attachment #8929062 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 14•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/383831f52344
Comment 15•6 years ago
|
||
noise |
We shipped 55 with this issue, the volume isn't crazy high, why should we take that in 57? Thanks
Flags: needinfo?(droeh)
Comment 16•6 years ago
|
||
Comment on attachment 8929062 [details] [diff] [review] Only load mozglue on supported hardware Actually, looking at the volume and the fact that we will do a fennec dot release anyway, taking it.
Attachment #8929062 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Updated•6 years ago
|
Flags: needinfo?(droeh)
Comment 17•6 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/c40c1a52ec1b866646b973d79052b9be84d8c7f0
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•