Fix missing DebuggingServer.removeContentServerScript

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: rpl, Assigned: rpl)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
I noticed the following error logged in the console while running devtools related tests:

```
GECKO(4890) | JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/devtools-browser.js, line 861: TypeError: DebuggerServer.removeContentServerScript is not a function
```

Currently it doesn't create any failure, that function has been added Bug 1364075 and I think that it has been removed in a rebase of other patches and got unnoticed because no tests fails.

I'm attaching a patch that adds the function definition back
(and in the meantime I'm looking at the best place to add a test for this).
Comment hidden (mozreview-request)

Comment 2

11 months ago
mozreview-review
Comment on attachment 8875324 [details]
Bug 1370925 - Fix missing DebuggingServer.removeContentServerScript.

https://reviewboard.mozilla.org/r/146736/#review150788

Thanks!
Attachment #8875324 - Flags: review?(jdescottes) → review+

Comment 3

11 months ago
mozreview-review
Comment on attachment 8875324 [details]
Bug 1370925 - Fix missing DebuggingServer.removeContentServerScript.

https://reviewboard.mozilla.org/r/146736/#review150792

::: devtools/server/main.js:1397
(Diff revision 1)
> +    try {
> +      Services.ppmm.broadcastAsyncMessage("debug:close-content-server");
> +    } catch (e) {
> +      // Nothing to do
> +    }
> +  }

missing ","
Comment hidden (mozreview-request)
(Assignee)

Updated

11 months ago
Assignee: nobody → lgreco
Status: NEW → ASSIGNED

Comment 5

11 months ago
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/d0c59bcdd5bc
Fix missing DebuggingServer.removeContentServerScript. r=jdescottes

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d0c59bcdd5bc
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.