Closed
Bug 1370975
Opened 7 years ago
Closed 7 years ago
Use the vs14 config for aom
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The aom configure script was using the x86-win32-gcc target, but we build win32 with cl from Visual Studio rather than gcc from cygwin. It's probably safer to use that config instead.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → giles
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8875363 [details] Bug 1370975 - aom: Use Visual Studio 14 configuration. https://reviewboard.mozilla.org/r/146782/#review151514 LGTM Could you please make a note somewhere, to update to Visual Studio 2017 (vs15?) when we switch to it -- maybe open a new bug dependent on bug 1318143?
Attachment #8875363 -
Flags: review?(gsquelart) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8875363 [details] Bug 1370975 - aom: Use Visual Studio 14 configuration. https://reviewboard.mozilla.org/r/146782/#review151514 Ok, thanks. I filed bug 1371439 about the followup.
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f274f4c10a92 aom: Use Visual Studio 14 configuration. r=gerald
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f274f4c10a92
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•