Closed Bug 1370976 Opened 8 years ago Closed 8 years ago

add webm MediaMIMEType gtest

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

This probably doesn't make much difference, but I worried that there were only mp4 examples in dom/media/gtest/TestMediaMIMETypes.cpp.
Assignee: nobody → giles
Comment on attachment 8875362 [details] Bug 1370976 - Add webm MediaMIMEType gtest. https://reviewboard.mozilla.org/r/146778/#review151510 The more the merrier, thank you for adding these. One and half nits please: (But don't sweat it if you don't have the time for that) ::: dom/media/gtest/TestMediaMIMETypes.cpp:187 (Diff revision 1) > + { "video/webm", "video/webm", false, false, true, false, false }, > + { "audio/webm", "audio/webm", false, true, false, false, false }, > { "application/x", "application/x", true, false, false, false, false } Could you please line up the last two bool in the "audio/webm" line, with the other lines around? (And while you're at it, please move the first 'false' of the "application/x" line one space to the right, thanks! -- Make sure you keep the others aligned.)
Attachment #8875362 - Flags: review?(gsquelart) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: