1371001 - Deleted breakpoints reappears after page reload.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Honza Bambas (:mayhemer)]

Windows, Nightly x64 official build from https://hg.mozilla.org/mozilla-central/rev/5801aa478de12a62b2b2982659e787fcc4268d67

STR:
- open console
- add some breaks points to JS on the page (a linked script on the same origin)
- debug for awhile
- delete all the breakpoints (which ever way - all or one by one)
- reload the page (while not paused in the debugger)
=> breakpoints reappear and annoy

Comment 1

[Honza Bambas (:mayhemer)]

(ok, only way is to delete one by one, but whatever..)

Comment 2

[:Harald Kirschner :digitarald]

Per Jason, this if fixed.

Comment 3

[Honza Bambas (:mayhemer)]

And per me, this is not fixed.  Happens to me again, not sure on initial STR, but from a certain moment when I delete all breakpoints on a page, reload the page while devtools/debugger is left open, breakpoints reappear again (fortunately disabled this time).

I think I may have pressed F5 when the page was in focus and paused in a debugger on a breakpoint.  This is the only thing coming to my mind that could cause this, but I'm not sure at all.

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Honza Bambas (:mayhemer) from comment #3)
> I think I may have pressed F5 when the page was in focus and paused in a
> debugger on a breakpoint.  This is the only thing coming to my mind that
> could cause this, but I'm not sure at all.

Forget about this str.  It happens all the time to me.

Comment 5

[Honza Bambas (:mayhemer)]

Looks like devtools.debugger.pending-breakpoints is filled with breakpoints that should have already been deleted.  This pref value length is 5k+ long.  There is some 15 or more leftovers.

There is a warning about writing this pref in the browser console, could that be the source of this bug?

" Warning: attempting to write 5906 bytes to preference devtools.debugger.pending-breakpoints. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes. "

Comment 6

[:Harald Kirschner :digitarald]

Jason, could the recovery logic improved that you added that resets the breakpoints when the server returns unexpected state?

Comment 7

[Honza Bambas (:mayhemer)]

BTW, after resetting the preference to "{}" this appeared very soon again (too long string to be stored).

Comment 8

[Jason Laster [:jlast]]

Sorry for the delay. This has been fixed and verified in dev-edition.