1371016 - aom: pass /arch:AVX2 when appropriate

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ralph Giles (:rillian)]

Per bug 1279593 /ARCH:AVX and /ARCH:AVX2 may be needed under msvc to avoid expensive state-change delays switching between SSE and AVX. Propagate that change to the aom moz.build.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1371016 - aom: Add /arch:AVX2 when compiling under msvc.

Propagate the libvpx AVX flag changes from bug 1279593.

This flag tells the compiler to generate AVX code
in these modules intead of using normal SSE instructions
which can trigger expensive state-switching.

NB: This should only be set for AVX-specific implementation
files; setting this flag for general code will invalidate
our runtime simd support checks.

Review commit: https://reviewboard.mozilla.org/r/146870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146870/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8875425 [details]
Bug 1371016 - aom: Add /arch:AVX2 when compiling under msvc.

https://reviewboard.mozilla.org/r/146870/#review153044

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff8a5005cfa0
aom: Add /arch:AVX2 when compiling under msvc. r=ted

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff8a5005cfa0

Comment 5

[Carsten Book [:Tomcat]]

i'm not sure but it seems that this change made failures like https://treeherder.mozilla.org/logviewer.html#?job_id=106997454&repo=autoland more worse


like (green)
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=287690a1fedccf65eafe6e26366794c1231a7cb9&filter-searchStr=Linux+opt+Mochitests+executed+by+TaskCluster+test-linux32%2Fopt-mochitest-browser-chrome-2+tc-M(bc2)

bad

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ff8a5005cfa023090b8390d2426da6f300ca6497&filter-searchStr=Linux+opt+Mochitests+executed+by+TaskCluster+test-linux32%2Fopt-mochitest-browser-chrome-2+tc-M(bc2)

Comment 6

[Carsten Book [:Tomcat]]

or better link 

https://treeherder.mozilla.org/#/jobs?repo=autoland&bugfiler&noautoclassify&filter-searchStr=Linux%20opt%20Mochitests%20executed%20by%20TaskCluster%20test-linux32%2Fopt-mochitest-browser-chrome-2%20tc-M(bc2)&fromchange=114fb8a5f56cdff35784193d3143039aa43b48c8&tochange=ff8a5005cfa023090b8390d2426da6f300ca6497

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/7c4ca88d519f
Backed out changeset ff8a5005cfa0 for making linux bc2 browser_windowStateContainer.js  crashes in @ RunWatchdog more worse

Comment 8

[(not currently active) Ted Mielczarek]

This patch changed compile flags for MSVC only, so I don't believe it had anything to do with linux test failures.

Comment 9

[Ralph Giles (:rillian)]

I don't see how this could have caused side effects either. The code isn't event built on windows by default.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ef55c10fa33
aom: Add /arch:AVX2 when compiling under msvc. r=ted

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ef55c10fa33