Heartbeat bar is black on OSX Nightly/Local Build

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: osmose, Assigned: mythmon)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

With both Nightly and a local build of Firefox, using the in-tree version of the Shield add-on, if I trigger a Heartbeat bar, the bar has a black background instead of a white one, rendering the text difficult to read. See the attached screenshot for an example.

Tested on Nightly 55.0a1 (2017-06-07).
Assignee: nobody → mcooper
The underlying issue here is that rules in chrome://global/skin/notification.css are overriding the rules in https://dxr.mozilla.org/mozilla-central/rev/a49112c7a5765802096b3fc298069b9495436107/browser/extensions/shield-recipe-client/skin/shared/Heartbeat.css

This isn't specific to OSX, but the failure case isn't as noticeable on other platforms. On other platforms the default notification color is light, so the overriding rule isn't a problem.
Comment on attachment 8876262 [details]
Bug 1371058 - Override default notification styles in Shield's Hearbeat.

https://reviewboard.mozilla.org/r/147704/#review152018
Attachment #8876262 - Flags: review?(dtownsend) → review+
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d09e630c7054
Override default notification styles in Shield's Hearbeat. r=mossop
https://hg.mozilla.org/mozilla-central/rev/d09e630c7054
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Product: Shield → Firefox
You need to log in before you can comment on or make changes to this bug.