1371065 - Remove the addon SDK from Firefox

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, enhancement)

Description

[Andy McKay]

This bug is to track removing the SDK from Firefox. Once we've landed no SDK add-ons on release for Firefox as per:

https://wiki.mozilla.org/Add-ons/Firefox57

... we'll remove the SDK from Firefox. How we'd do this and impact on other platforms (eg. Thunderbird) will need to be discussed.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/

Review commit: https://reviewboard.mozilla.org/r/177964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177964/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1371065: Part 1 - Remove external references to the SDK.

Review commit: https://reviewboard.mozilla.org/r/177966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177966/

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1371065: Part 2 - rm -rf addon-sdk

Review commit: https://reviewboard.mozilla.org/r/177968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177968/

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8906201 [details]
Bug 1371065: Part 1 - Remove external references to the SDK.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177966/diff/1-2/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8906202 [details]
Bug 1371065: Part 2 - rm -rf addon-sdk

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177968/diff/1-2/

Comment 6

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8906200 [details]
Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/

https://reviewboard.mozilla.org/r/177964/#review183398

Comment 7

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8906202 [details]
Bug 1371065: Part 2 - rm -rf addon-sdk

https://reviewboard.mozilla.org/r/177968/#review183400

Comment 8

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8906201 [details]
Bug 1371065: Part 1 - Remove external references to the SDK.

https://reviewboard.mozilla.org/r/177966/#review183430

Comment 9

[Mike Hommey [:glandium]]

The bug title got me confused, as I was thinking "but we removed the Firefox SDK in bug 1333826"!

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8906201 [details]
Bug 1371065: Part 1 - Remove external references to the SDK.

https://reviewboard.mozilla.org/r/177966/#review183628

::: toolkit/modules/moz.build:157
(Diff revision 2)
>  XPCSHELL_TESTS_MANIFESTS += ['tests/xpcshell/xpcshell.ini']
>  BROWSER_CHROME_MANIFESTS += ['tests/browser/browser.ini']
>  MOCHITEST_CHROME_MANIFESTS += ['tests/chrome/chrome.ini']
>  
>  TESTING_JS_MODULES += [
> +    'HiddenFrame.jsm',

The HiddenFrame change seems like it would be more appropriate in a separate patch with a proper commit message (or even a followup bug).

Comment 11

[Kris Maglione [:kmag]]

(In reply to Mike Hommey [:glandium] from comment #9)
> The bug title got me confused, as I was thinking "but we removed the Firefox
> SDK in bug 1333826"!

Heh. I'll admit, it confused me too. I actually couldn't even find the bug when I looked for it because there was no add-on/addon/jetpack in the title...

Comment 12

[Kris Maglione [:kmag]]

Comment on attachment 8906201 [details]
Bug 1371065: Part 1 - Remove external references to the SDK.

https://reviewboard.mozilla.org/r/177966/#review183628

> The HiddenFrame change seems like it would be more appropriate in a separate patch with a proper commit message (or even a followup bug).

Jetpack was the last non-test consumer of it, so without this change, browser_all_files_referenced failed. I thought about adding an exception instead, but not shipping unused code seemed better than shipping it. I guess I'll add an exception for now and move this change to a follow-up, though.

Comment 13

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46b8854f1f8e710947d857af39e7933e08c7f868
Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/ r=Mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/f725597fa0b41856bd0d46b7bb2c4feaaca101c7
Bug 1371065: Part 1 - Remove external references to the add-on SDK. r=Mossop,glandium

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff42bbbfcc3f20e2bc0fac0216419e43186f04d0
Bug 1371065: Part 2 - rm -rf addon-sdk r=Mossop

Comment 14

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0d78a70953c589f5c62f527f7f95881492d3a6
Bug 1371065: Follow-up: Fix emitter sandbox validation bustage. r=me CLOSED TREE

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/46b8854f1f8e
https://hg.mozilla.org/mozilla-central/rev/f725597fa0b4
https://hg.mozilla.org/mozilla-central/rev/ff42bbbfcc3f
https://hg.mozilla.org/mozilla-central/rev/2d0d78a70953

Comment 16

[kernp25]

This observer still exists:
https://dxr.mozilla.org/mozilla-central/search?q=content-contextmenu&redirect=false

It was used by the addon SDK.

Comment 17

[(no longer active)]

(In reply to kernp25 from comment #16)
> This observer still exists:
> https://dxr.mozilla.org/mozilla-central/search?q=content-
> contextmenu&redirect=false
> 
> It was used by the addon SDK.

Filed bug 1401028 to remove it.

Comment 18

[[github robot]]

Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/b59561d4085489d7efb21391c8b30b3bb737a5b2
Sync changes from mozilla-central.

- Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/ r=Mossop
  https://hg.mozilla.org/mozilla-central/rev/46b8854f1f8e
- Bug 1398050 - Polish preferences page to match visual spec. r=mconley
  https://hg.mozilla.org/mozilla-central/rev/8918870e7a20