Closed Bug 1371073 Opened 4 years ago Closed 4 years ago
Add tests to ensure changing number of rows or columns in a frameset works as expected
59 bytes, text/x-review-board-request
I noticed that some incorrect code that I wrote where (effectively) |HTMLFrameSetElement::mCurrentRowColHint| was always set to |NS_STYLE_HINT_REFLOW| broke no tests. Manual tests for this already exist at these locations: - https://bug48422.bmoattachments.org/attachment.cgi?id=90746 - https://bug48422.bmoattachments.org/attachment.cgi?id=90747 When these tests are run with the buggy code I wrote, the frames seem to be added fine, but when removed, nothing is displayed on the page.
Attachment #8877788 - Flags: review?(bzbarsky)
Comment on attachment 8877788 [details] Bug 1371073 - Add reftests to ensure rows and cols are properly added and removed from framesets https://reviewboard.mozilla.org/r/149214/#review154304 r=me. Did you happen to check whether some of these fail with the buggy bits from bug 1365092?
Attachment #8877788 - Flags: review?(bzbarsky) → review+
I did check and the "remove" tests both fail in that situation.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9afdcc193530 Add reftests to ensure rows and cols are properly added and removed from framesets r=bz
You need to log in before you can comment on or make changes to this bug.