Fix unified builds when adding a PaintThread

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Bug 1369549 adds a paint thread. I guess in it's position, we split up the unified builds in such a way where they started breaking. I dug around and it looks like we just had some missing includes / lucky includes.
Attachment #8875521 - Flags: review?(bugmail)
Comment on attachment 8875521 [details] [diff] [review]
Fix broken includes

Review of attachment 8875521 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments addressed. Also please -U8 when generating patches in the future.

::: gfx/layers/DirectionUtils.h
@@ +14,2 @@
>  
>  using layers::ScrollDirection;

Remove this using statement

::: gfx/layers/wr/WebRenderScrollData.cpp
@@ +6,5 @@
>  #include "mozilla/layers/WebRenderScrollData.h"
>  #include "mozilla/Unused.h"
>  #include "nsTArray.h"
> +#include "Layers.h"
> +#include "UnitTransforms.h"

Rearrange like so:

#include "mozilla/layers/WebRenderScrollData.h"

#include "Layers.h"
#include "mozilla/Unused.h"
#include "nsTArray.h"
#include "UnitTransforms.h"

::: gfx/layers/wr/WebRenderScrollData.h
@@ +11,4 @@
>  #include "chrome/common/ipc_message_utils.h"
>  #include "FrameMetrics.h"
>  #include "LayersTypes.h"
> +#include "ipc/IPCMessageUtils.h"

Move this include up one line so it's in alphabetical order

@@ +15,2 @@
>  #include "mozilla/Maybe.h"
> +#include "mozilla/layers/LayerAttributes.h"

Ditto, this should go above Maybe.h
Attachment #8875521 - Flags: review?(bugmail) → review+
(Assignee)

Comment 2

2 years ago
Try looks good, updated with fixes from kats

Comment 4

2 years ago
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3441eaf103a1
Fix unified builds when adding a PaintThread. r=kats

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3441eaf103a1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.