Closed
Bug 1371100
Opened 7 years ago
Closed 7 years ago
Intermittent dom/tests/browser/browser_noopener.js | Should have usercontextid set for (#test8|#test11) (private=false, container=true, alwaysNewWindow=true) - Got , expected 1
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: nika)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:race])
Attachments
(1 file)
2.43 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=105352946&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/XzCRODOdTgewF3r804sADA/runs/0/artifacts/public/logs/live_backing.log
This is happening pretty frequently.
Flags: needinfo?(michael)
Assignee | ||
Updated•7 years ago
|
Summary: Intermittent dom/tests/browser/browser_noopener.js | Should have usercontextid set for #test8 (private=false, container=true, alwaysNewWindow=true) - Got , expected 1 → Intermittent dom/tests/browser/browser_noopener.js | Should have usercontextid set for (#test8|#test11) (private=false, container=true, alwaysNewWindow=true) - Got , expected 1
Assignee | ||
Comment 3•7 years ago
|
||
This is necessary because we asynchronously send the updated UserContextId back from the child to the parent process, and we would occasionally lose the race on infrastructure causing us to see the non-updated version. With this change we explicitly ask the content process, which is not racey. MozReview-Commit-ID: LODNi1YmBI8
Attachment #8875791 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8875791 -
Flags: review?(bugs) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/66a83f17d67b Check userContextId in the content process instead of in the chrome process, r=smaug
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → michael
Flags: needinfo?(michael)
Comment hidden (Intermittent Failures Robot) |
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/66a83f17d67b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell fixed:race]
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•