1371109 - [Fennec] Enable layout/reftests/webm-video/poster-xxx.html

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1371109 - Enable webm-video/poster-xxx.html .

Review commit: https://reviewboard.mozilla.org/r/146976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146976/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8875560 [details]
Bug 1371109 - Enable webm-video/poster-xxx.html .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146976/diff/1-2/

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8875560 [details]
Bug 1371109 - Enable webm-video/poster-xxx.html .

https://reviewboard.mozilla.org/r/146976/#review151140

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8875560 [details]
Bug 1371109 - Enable webm-video/poster-xxx.html .

https://reviewboard.mozilla.org/r/146976/#review151146

::: layout/reftests/webm-video/reftest.list:23
(Diff revision 2)
>  skip-if(Android) HTTP(..) == offset-1.xhtml offset-1-ref.html
>  random skip-if(Android) HTTP(..) == object-aspect-ratio-2a.xhtml aspect-ratio-2-ref.html
>  random skip-if(Android) HTTP(..) == object-aspect-ratio-2b.xhtml aspect-ratio-2-ref.html
>  skip-if(Android) fuzzy-if(winWidget,1,56000) fuzzy-if(cocoaWidget,1,56000) HTTP(..) == zoomed-1.xhtml zoomed-1-ref.html # bug 778995 for fuzzy
> -skip-if(Android) fails-if(styloVsGecko) == poster-1.html poster-ref-blue250x200.html
> -skip-if(Android) fails-if(styloVsGecko) == poster-2.html poster-ref-black140x100.html
> +fails-if(styloVsGecko) == poster-1.html poster-ref-blue250x200.html
> +fails-if(Android) fails-if(styloVsGecko) == poster-2.html poster-ref-black140x100.html

poster-2.html fails because the default preload action for mobile app is none.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f776e85cbb58
Enable webm-video/poster-xxx.html . r=alwu

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddabdf4ac222
Followup to annotate some frequently failing android reftests r=me a=me

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

poster-3.html and poster-5.html were consistently failing in the autophone reftest suite like https://treeherder.mozilla.org/logviewer.html#?job_id=105637270&repo=autoland

Those jobs are tier-2, so no backout for breaking them. Hopefully fails-if(android) was the right annotation for these, and that doesn't hurt anything else outside of these autophone reftests.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07a573e7aef3
Use random-if instead of fails-if due to unexpected passes elsewhere r=me a=me

Comment 9

[Benjamin Chen [:bechen]]

The fail log of poster-3 and poster-5 are "max difference: 2, number of differing pixels: 14000", it is a good new to us.
Because the max difference is 2, that means there are 14000 pixels which RGB difference is less than 2. Implies the video decoding content is correct so we should use fuzzy-if() to address them.

Comment 10

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31d8fd4415e7

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There was also this failure that included poster-12, but that seemed much less frequent: https://treeherder.mozilla.org/logviewer.html#?job_id=105660355&repo=autoland

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #11)
> There was also this failure that included poster-12, but that seemed much
> less frequent:
> https://treeherder.mozilla.org/logviewer.html#?job_id=105660355&repo=autoland

Ooh, poster-12 was a crash.

Comment 13

[Benjamin Chen [:bechen]]

(In reply to Wes Kocher (:KWierso) from comment #12)
> (In reply to Wes Kocher (:KWierso) from comment #11)
> > There was also this failure that included poster-12, but that seemed much
> > less frequent:
> > https://treeherder.mozilla.org/logviewer.html#?job_id=105660355&repo=autoland
> 
> Ooh, poster-12 was a crash.

See bug 1370227. It is the same crash.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f776e85cbb58
https://hg.mozilla.org/mozilla-central/rev/ddabdf4ac222
https://hg.mozilla.org/mozilla-central/rev/07a573e7aef3