1371114 - Add gecko profiler label for WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Peter Chang[:pchang]]

With WR, we change the rasterization and composition flow. Therefore, we need to add labels for WR case.

Comment 1

[Peter Chang[:pchang]]

I just added labels for RenderLayer/SendWRCmds/CompositeToTarget/Composite(RenderThread).
This is the profiler link.

https://perfht.ml/2rDYMjb

Comment 2

[Peter Chang[:pchang]]

Attachment: Bug 1371114 - Add gecko profiler labels for WebRender,

Review commit: https://reviewboard.mozilla.org/r/147400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147400/

Comment 3

[Peter Chang[:pchang]]

With gecko changes, we also need to change dev tool to create a row to display 'Renderer thread' labels.
I will fire another git push request for it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8875990 [details]
Bug 1371114 - Add gecko profiler labels for WebRender,

https://reviewboard.mozilla.org/r/147400/#review151804

::: gfx/layers/wr/WebRenderLayerManager.cpp:232
(Diff revision 1)
>  
>    bool sync = mTarget != nullptr;
>    mLatestTransactionId = mTransactionIdAllocator->GetTransactionId();
>  
> +  {
> +    GeckoProfilerTracingRAII tracer("Paint", "ForwardDPTransaction");

It's probably worth distinguishing the sync vs !sync cases here. Maybe just replace the marker with sync ? "ForwardDPTransactionSync" : "ForwardDPTransaction"

::: gfx/webrender_bindings/RenderThread.cpp:182
(Diff revision 1)
>  }
>  
>  void
>  RenderThread::UpdateAndRender(wr::WindowId aWindowId)
>  {
> +

Drop empty line

Comment 5

[Peter Chang[:pchang]]

Comment on attachment 8875990 [details]
Bug 1371114 - Add gecko profiler labels for WebRender,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147400/diff/1-2/

Comment 6

[Peter Chang[:pchang]]

Comment on attachment 8875990 [details]
Bug 1371114 - Add gecko profiler labels for WebRender,

https://reviewboard.mozilla.org/r/147400/#review151804

> It's probably worth distinguishing the sync vs !sync cases here. Maybe just replace the marker with sync ? "ForwardDPTransactionSync" : "ForwardDPTransaction"

Done

> Drop empty line

Done

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2629ca0641a7
Add gecko profiler labels for WebRender, r=kats

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2629ca0641a7