Closed Bug 1371114 Opened 2 years ago Closed 2 years ago

Add gecko profiler label for WebRender

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: pchang, Assigned: pchang)

Details

Attachments

(1 file)

With WR, we change the rasterization and composition flow. Therefore, we need to add labels for WR case.
I just added labels for RenderLayer/SendWRCmds/CompositeToTarget/Composite(RenderThread).
This is the profiler link.

https://perfht.ml/2rDYMjb
With gecko changes, we also need to change dev tool to create a row to display 'Renderer thread' labels.
I will fire another git push request for it.
Assignee: nobody → howareyou322
Comment on attachment 8875990 [details]
Bug 1371114 - Add gecko profiler labels for WebRender,

https://reviewboard.mozilla.org/r/147400/#review151804

::: gfx/layers/wr/WebRenderLayerManager.cpp:232
(Diff revision 1)
>  
>    bool sync = mTarget != nullptr;
>    mLatestTransactionId = mTransactionIdAllocator->GetTransactionId();
>  
> +  {
> +    GeckoProfilerTracingRAII tracer("Paint", "ForwardDPTransaction");

It's probably worth distinguishing the sync vs !sync cases here. Maybe just replace the marker with sync ? "ForwardDPTransactionSync" : "ForwardDPTransaction"

::: gfx/webrender_bindings/RenderThread.cpp:182
(Diff revision 1)
>  }
>  
>  void
>  RenderThread::UpdateAndRender(wr::WindowId aWindowId)
>  {
> +

Drop empty line
Attachment #8875990 - Flags: review?(bugmail) → review+
Comment on attachment 8875990 [details]
Bug 1371114 - Add gecko profiler labels for WebRender,

https://reviewboard.mozilla.org/r/147400/#review151804

> It's probably worth distinguishing the sync vs !sync cases here. Maybe just replace the marker with sync ? "ForwardDPTransactionSync" : "ForwardDPTransaction"

Done

> Drop empty line

Done
Pushed by pchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2629ca0641a7
Add gecko profiler labels for WebRender, r=kats
https://hg.mozilla.org/mozilla-central/rev/2629ca0641a7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.