Closed
Bug 1371116
Opened 7 years ago
Closed 7 years ago
Remove nsJSEnvironment::sContext
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
|
10.18 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
This global variable causes trouble for Quantum DOM since we'll have one context per thread. It's pretty easy to remove it in place of AutoJSAPI though. One note: I also removed the code that stores the context in the user pointer of an async task (see StartAsyncTaskCallback). This code is only used for an assertion, and this assertion will no longer be valid in Quantum DOM. An async task that is created on one thread can finish on another thread.
Attachment #8875546 -
Flags: review?(continuation)
|
||
Updated•7 years ago
|
Attachment #8875546 -
Flags: review?(continuation) → review+
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc624eb77e1 Remove nsJSEnvironment::sContext (r=mccr8)
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ccc624eb77e1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•