Remove nsJSEnvironment::sContext

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
This global variable causes trouble for Quantum DOM since we'll have one context per thread. It's pretty easy to remove it in place of AutoJSAPI though.

One note: I also removed the code that stores the context in the user pointer of an async task (see StartAsyncTaskCallback). This code is only used for an assertion, and this assertion will no longer be valid in Quantum DOM. An async task that is created on one thread can finish on another thread.
Attachment #8875546 - Flags: review?(continuation)
Attachment #8875546 - Flags: review?(continuation) → review+
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc624eb77e1
Remove nsJSEnvironment::sContext (r=mccr8)
https://hg.mozilla.org/mozilla-central/rev/ccc624eb77e1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.