137112 - [Pressing back button rapidly causes crash. [@ GetNormalLineHeight]

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[WD]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+)
Gecko/20020411
BuildID:    2002041103

Mozilla crashed on me when pressing the back button a couple times rapidly.   

Reproducible: Always
Steps to Reproduce:
1.Go to:
http://www.google.com/search?q=Distributing+SQL+Server+with+Applications&sourceid=mozilla-search&start=0&start=0
2.Click on the first search match
3.Click on the link near the top " Distributing SQL Server Client Components."
4.Click back 3x fast
5.Click Forward 3x and repeat step 4 as necessary

Actual Results:  Mozilla crashes

Expected Results:  No Crash

TB5121152H
TB5120867W
TB5120784K

Possibly related to bug 133164 ?   Without having Talkback access, I can't tell...

Comment 1

[Frederic Bezies]

In order to help, I reproduced this bug and sent a talkback.

TB5128613W.

Comment 2

[Doron Rosenberg (IBM)]

Stack Signature  GetNormalLineHeight abeaa1ed
Trigger Time 2002-04-12 07:22:24
Email Address
URL visited
Build ID 2002041106
Product ID MozillaTrunk
Platform
Operating System Win32
Module
Trigger Reason Access violation
User Comments Pressed the back button rapidly
Stack Trace
GetNormalLineHeight
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp, line 2239]
ComputeLineHeight
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp, line 2320]
nsHTMLReflowState::CalcLineHeight
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp, line 2335]
nsBlockReflowState::nsBlockReflowState
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowState.cpp, line 179]
nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 735]
nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 807]
CanvasFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLFrame.cpp, line 565]
nsBoxToBlockAdaptor::Reflow
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxToBlockAdaptor.cpp, line 845]
nsBoxToBlockAdaptor::DoLayout
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxToBlockAdaptor.cpp, line 622]
nsBox::Layout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp, line 1052]
nsScrollBoxFrame::DoLayout
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsScrollBoxFrame.cpp, line 395]
nsBox::Layout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp, line 1052]
nsContainerBox::LayoutChildAt
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsContainerBox.cpp, line 650]
nsGfxScrollFrameInner::LayoutBox
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp, line 1063]
nsGfxScrollFrameInner::Layout
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp, line 1222]
nsGfxScrollFrame::DoLayout
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp, line 1071]
nsBox::Layout [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp, line 1052]
nsBoxFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxFrame.cpp, line 1001]
nsGfxScrollFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsGfxScrollFrame.cpp, line 780]
nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 807]
ViewportFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsViewportFrame.cpp, line 588]
PresShell::InitialReflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 2677]
HTMLContentSink::StartLayout
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLContentSink.cpp,
line 3975]
HTMLContentSink::DidBuildModel
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLContentSink.cpp,
line 2770]
CNavDTD::DidBuildModel [d:\builds\seamonkey\mozilla\htmlparser\src\CNavDTD.cpp,
line 658]
nsParser::DidBuildModel
[d:\builds\seamonkey\mozilla\htmlparser\src\nsParser.cpp, line 1253]
nsParser::Terminate [d:\builds\seamonkey\mozilla\htmlparser\src\nsParser.cpp,
line 1333]
nsHTMLDocument::StopDocumentLoad
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLDocument.cpp, line
1056]
DocumentViewerImpl::Stop
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp, line 1588]
nsDocShell::Stop [d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line
2447]
nsDocShell::Stop [d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line
2468]
nsDocShell::Destroy [d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp,
line 2681]
nsWebShell::Destroy [d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp,
line 1264]
nsHTMLFrameInnerFrame::~nsHTMLFrameInnerFrame
[d:\builds\seamonkey\mozilla\layout\html\document\src\nsFrameFrame.cpp, line 675]
nsHTMLFrameInnerFrame::`scalar deleting destructor'
nsFrame::Destroy [d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrame.cpp,
line 469]
nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp, line 131]
nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 141]
nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp, line 131]
nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 141]
nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp, line 131]
nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 141]
nsLineBox::DeleteLineList
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsLineBox.cpp, line 312]
nsBlockFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp, line 330]
nsAreaFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsAreaFrame.cpp, line 169]
nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp, line 131]
nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 141]
nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp, line 131]
nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 141]
nsBoxFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxFrame.cpp, line 1241]
nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp, line 131]
nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp, line 141]
ViewportFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsViewportFrame.cpp, line 157]
FrameManager::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp, line 517]
PresShell::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 1714]
DocumentViewerImpl::Destroy
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp, line 1572]

Comment 3

[Matthias Versen [:Matti]]

-> Layout

Comment 4

[Christine Hoffman]

Changing QA contact

Comment 5

[WD]

Note:

I can only seem to reproduce this bug with the Trunk builds.   1.0.0 branch
builds seem fine.

Comment 6

[Jay Patel [:jay]]

Adding topcrash+ and testcase keywords.  This has become a topcrasher on the
MozillaTrunk.  It first appeared in builds on 4/11...there were no crashes like
this before then.  Here is the latest Talkback data:

GetNormalLineHeight   27 
BBID range: 5085946 - 5245045
Min/Max Seconds since last crash: 39 - 27120
Min/Max Runtime: 96 - 48509
Crash data range: 2002-04-11 to 2002-04-15
Build ID range: 2002041106 to 2002041510
Keyword List : back(5), button(5), 
Stack Trace: 

	 GetNormalLineHeight
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp  line 2239]
	 ComputeLineHeight
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp  line 2320]
	 nsHTMLReflowState::CalcLineHeight
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLReflowState.cpp  line 2335]
	 nsBlockReflowState::nsBlockReflowState
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockReflowState.cpp  line 179]
	 nsBlockFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsBlockFrame.cpp  line 735]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 807]
	 CanvasFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsHTMLFrame.cpp  line 565]
	 nsBoxToBlockAdaptor::Reflow
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxToBlockAdaptor.cpp  line 837]
	 nsBoxToBlockAdaptor::DoLayout
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxToBlockAdaptor.cpp  line 619]
	 nsBox::Layout
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp  line 1052]
	 nsScrollBoxFrame::DoLayout
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsScrollBoxFrame.cpp  line 395]
	 nsBox::Layout
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBox.cpp  line 1052]
	 nsBoxFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxFrame.cpp  line 1001]
	 nsContainerFrame::ReflowChild
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 807]
	 ViewportFrame::Reflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsViewportFrame.cpp  line 588]
	 PresShell::InitialReflow
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 2677]
	 HTMLContentSink::StartLayout
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLContentSink.cpp 
line 3987]
	 HTMLContentSink::DidBuildModel
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLContentSink.cpp 
line 2773]
	 CNavDTD::DidBuildModel
[d:\builds\seamonkey\mozilla\htmlparser\src\CNavDTD.cpp  line 657]
	 nsParser::DidBuildModel
[d:\builds\seamonkey\mozilla\htmlparser\src\nsParser.cpp  line 1253]
	 nsParser::Terminate
[d:\builds\seamonkey\mozilla\htmlparser\src\nsParser.cpp  line 1333]
	 nsHTMLDocument::StopDocumentLoad
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLDocument.cpp  line
1058]
	 DocumentViewerImpl::Stop
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp  line 1597]
	 nsDocShell::Stop
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line 2447]
	 nsDocShell::Stop
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line 2468]
	 nsDocShell::Destroy
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line 2681]
	 nsWebShell::Destroy
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp  line 1264]
	 nsHTMLFrameInnerFrame::~nsHTMLFrameInnerFrame
[d:\builds\seamonkey\mozilla\layout\html\document\src\nsFrameFrame.cpp  line 675]
	 nsHTMLFrameInnerFrame::`scalar deleting destructor'
	 nsFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrame.cpp  line 469]
	 nsFrameList::DestroyFrames
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp  line 131]
	 nsContainerFrame::Destroy
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsContainerFrame.cpp  line 141]
	 nsFrameList::DestroyFrame
[d:\builds\seamonkey\mozilla\layout\base\src\nsFrameList.cpp  line 218]
	 nsBoxFrame::RemoveFrame
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsBoxFrame.cpp  line 1295]
	 FrameManager::RemoveFrame
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsFrameManager.cpp  line 1015]
	 nsCSSFrameConstructor::ContentRemoved
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp 
line 9680]
	 StyleSetImpl::ContentRemoved
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp  line 1536]
	 PresShell::ContentRemoved
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 5220]
	 nsXULDocument::ContentRemoved
[d:\builds\seamonkey\mozilla\content\xul\document\src\nsXULDocument.cpp  line 2202]
	 nsXULElement::RemoveChildAt
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line 2447]
	 nsXULElement::RemoveChild
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line 1134]
	 XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 106]
	 XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line 2027]
	 XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1267]
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 790]
	 js_Interpret
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 2746]
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 806]
	 js_InternalInvoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 881]
	 JS_CallFunctionValue
[d:\builds\seamonkey\mozilla\js\src\jsapi.c  line 3414]
	 nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 1019]
	 nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 182]
	 nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1218]
	 nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
2210]
	 nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line 3461]
	 PresShell::HandleDOMEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6139]
	 nsButtonBoxFrame::MouseClicked
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp  line 195]
	 nsButtonBoxFrame::HandleEvent
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp  line 142]
	 PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6108]
	 PresShell::HandleEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6059]
	 nsEventStateManager::CheckForAndDispatchClick
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp  line 2624]
	 nsEventStateManager::PostHandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp  line 1705]
	 PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6112]
	 PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6014]
	 nsViewManager::HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp  line 2076]
 
 	Source File :
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/html/base/src/nsHTMLReflowState.cpp
line : 2239
     (5228866)	Comments: I had one window and 4 tabs open. I selected close tab on the 4th
tab when mozilla crashed.=======================================Mozilla
0.9.9+Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.9+) Gecko/20020415
     (5228866)	Comments:
=======================================[e-mail] (if you
enter it as a bug  please include my email address in it.)
     (5218454)	URL: www.newsnow.co.uk
     (5218454)	Comments: just general browsing - clicked on a link and BAM! 
     (5206650)	Comments: failure occurred within the Mail. I was trying to move a message
(drag&drop) from an IMAP4 folder to a folder (at Local folders) and the program
crashed.
     (5205178)	URL: http://www.hotmail.com
     (5205178)	Comments: deleting junkmail
     (5176677)	URL: www.ffshrine.com
     (5176677)	Comments: Clicked on one of their main news links
     (5175313)	URL: http://www.fflegend.com/forums/
     (5175313)	Comments: Clicked on a forum link
     (5167383)	URL: http://www.cdrinfo.com/software/clonecd/index.shtml
     (5167383)	Comments: was browsing through the whole 15 pages of clonecd guide in a 2nd
tab of mozilla (1st tab the clonecd homepage  2nd tab this guide  no other
tabs).from page 15 the link was to this
url:http://www.cdrinfo.com/software/clonecd/index.shtmli clicked
     (5167383)	Comments:  stop (or close tab [x] button  don't remember).the browser
crashed.good luck.
     (5159970)	Comments: opening gif's on my hard drive in tabs
     (5132059)	URL: I was sitting on www.msn.com.
     (5132059)	Comments: I was trying to hide the "Whats Related" tab when it was selected
and off looking for something.
     (5128613)	Comments: verifying a bug.
     (5122684)	Comments: Pressed Back button rapidly
     (5122121)	Comments: Pressed Back button several times fast
     (5121152)	Comments: Pressed the back button rapidly
     (5120867)	Comments: Pressed back and forward very fast
     (5120784)	Comments: Pressed the back button a couple times quickly
     (5085946)	Comments: Looking for how to disable icons in the navigation bar... feature
seems to have disappeared... Clicked "OK"  crashed.

Was there a checkin on 4/11 that might have caused this crash to appear? 
Nominating for nsbeta1 since this might be some sort of regression.

Comment 7

[Jaime Rodriguez, Jr.]

nsbeta1+/adt2. This is bad, but I don't believe a large number of users would be
doing this type of behavior.

Comment 8

[Marc Attinasi]

This looks like yet another case of a null nsFontMetrics where we do not expect
it. I'll look at what changed on the trunk to expose this problem...

Comment 9

[Marc Attinasi]

shanjian added the code that is crashing (nsHTMLREflowState.cpp change).

ComputeLineHeight needs to check the nsFontMetrics |fm| against null before
calling  GetNormalLineHeight, which cannot take a null argument according to the
PRECONDITION.

Patch coming up...

Comment 10

[Marc Attinasi]

Attachment: PATCH: check for null fontMetrics and avoid using it id null

We have seen many examples where we are assuming that an nsFontMetrics instance
can be had from teh deviceContext, but it cannot (due presumably to resource
depletion). This is just another case of protecting caller code from null,
since there is no guarantee that it will be non-null.

Comment 11

[Marc Attinasi]

Attachment: PATCH: check for null fontMetrics and avoid using it if null

We have seen many examples where we are assuming that an nsFontMetrics instance
can be had from teh deviceContext, but it cannot (due presumably to resource
depletion). This is just another case of protecting caller code from null,
since there is no guarantee that it will be non-null.

Comment 12

[Marc Attinasi]

Comment on attachment 79874 [details] [diff] [review]
PATCH: check for null fontMetrics and avoid using it id null

Patch was somehow double-submitted. Anyway, I cannot reproduce this, so it is a
stab in the dark. However, I beieve that it is the correct thing to do, since I
know that we cannot guarantee that an nsFontMetrics instance will always be
provided.

Comment 13

[Marc Attinasi]

setting moz 1.0 milestone for NSBETA1+ bug...

Comment 14

[Shanjian Li]

Comment on attachment 79875 [details] [diff] [review]
PATCH: check for null fontMetrics and avoid using it if null

r=shanjian, (my fault. fm was null checked in existing code before my change.
This batch was not checked into branch though, and most likely it will never do
because some other issues.)

Comment 15

[Shanjian Li]

To further clearify, we don't want to check in patch 76097 (which caused this
problem) to branch because it is too risky. We will keep the patch in trunk and
for future as long as there is no serious regression that can't be cured.

Comment 16

[kinmoz]

Comment on attachment 79875 [details] [diff] [review]
PATCH: check for null fontMetrics and avoid using it if null

You meant for this to be an NS_ASSERTION call right?


+    NS_WARNING(fm, "null font metrics for the device context - we have to fix
this someday...");


NS_WARNING only takes one arg, a string. Fix that and you got an
sr=[e-mail].

Comment 17

[Marc Attinasi]

Thanks kin.

I want a WARNING not not an ASSERTION because we know that the fontMetrics can
be null, so asserting that it is not null is a mistake. Also, I noticed my
misuse of the NS_WARNING macro when I tried to compile (good catch on your
part!), and changed it to this:

if (!fm) {
  NS_WARNING( "null font metrics for the device context - we have to fix this
someday...");
    }

I failed to update the patch for the bug though, but it will be checked in
correctly.

Comment 18

[Marc Attinasi]

This is ready for the trunk. Will check in when the trunk is stable..

Comment 19

[Marc Attinasi]

Checked in to trunk.

Comment 20

[Jaime Rodriguez, Jr.]

moied - can y ou verify this on the trunk, and check for possible regressions?
thanks!

Comment 21

[Moied]

Marking Verified - the above listed test scenario's, dupes and URL did not have
any problems with build ID 2002042608(trunk) on winxp.