1371123 - Move OMTA test stuffs in PLayerTransaction out of PLayerTransaction

Status: RESOLVED INVALID

(Core :: Graphics: Layers, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

We could move Move OMTA test stuffs in PLayerTransaction out of PLayerTransaction.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1371123 part 1 - Move OMTA test stuffs in PLayerTransaction out of PLayerTransaction.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1371123 part 2 - Add new test IPDL message to sync-messages.ini.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1371123 part 1 - Move OMTA test stuffs in PLayerTransaction out of PLayerTransaction

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96495ec8a085f05a0462ffa0e02cb5d26b75fcdd

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8875605 [details] [diff] [review]
Bug 1371123 part 1 - Move OMTA test stuffs in PLayerTransaction out of PLayerTransaction

Review of attachment 8875605 [details] [diff] [review]:
-----------------------------------------------------------------

The problem with doing it this way is that the parent side is assumjng the layers id coming from the child is correct. In fact, a hijacked child process could spoof the layers id and start manipulating the parent side data structures for a different tab in a different content process. It doesn't matter that this is a test-only API because the code is still in production and we have to assume that a hijacked content process will be able to invoke the APIs.