Closed Bug 1371142 Opened 8 years ago Closed 7 years ago

Intermittent browser_subdialogs.js | sub-dialog should be unloaded - "subdialog.xul" == "about:blank" -

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jaws)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1371142 - Confirm that the page loaded is about:blank before continuing with the test.
59 bytes, text/x-review-board-request
Gijs
: review+
Details
Summary: Intermittent browser/components/preferences/in-content-new/tests/browser_subdialogs.js | sub-dialog should be unloaded - "chrome://mochitests/content/browser/browser/components/preferences/in-content-new/tests/subdialog.xul" == "about:blank" - → Intermittent browser_subdialogs.js | sub-dialog should be unloaded - "subdialog.xul" == "about:blank" -
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=158038675&repo=mozilla-central&lineNumber=25853 19:56:56 INFO - 558 INFO canceling the dialog 19:56:56 INFO - 559 INFO waiting for dialogclosing 19:56:56 INFO - 560 INFO waiting for about:blank load 19:56:56 INFO - 561 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | overlay is not visible - "hidden" != "visible" - 19:56:56 INFO - 562 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | inline styles should be cleared - "" == "" - 19:56:56 INFO - 563 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | sub-dialog should be unloaded - "about:blank" == "about:blank" - 19:56:56 INFO - 564 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | closing event should indicate button was 'null' - null == null - 19:56:56 INFO - 565 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | should be 1 if accepted, 0 if canceled, undefined if closed w/out button - "undefined" == "undefined" - 19:56:56 INFO - 566 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | dialog count should decrease by 1 - 0 == 0 - 19:56:56 INFO - 567 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | stack children count should decrease by 1 - 1 == 1 - 19:56:56 INFO - 568 INFO Leaving test bound back_navigation_on_subdialog_should_close_dialog 19:56:56 INFO - 569 INFO Entering test bound back_navigation_on_browser_tab_should_close_dialog 19:56:56 INFO - 570 INFO waiting for subdialog DOMFrameContentLoaded 19:56:56 INFO - Buffered messages logged at 19:56:55 19:56:56 INFO - 571 INFO waiting for subdialog load 19:56:56 INFO - 572 INFO subdialog window is loaded 19:56:56 INFO - 573 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | The dialog should be non-null - true == true - 19:56:56 INFO - 574 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | Subdialog URL should not be about:blank - "chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/subdialog.xul" != "about:blank" - 19:56:56 INFO - 575 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | Overlay should be visible - "visible" == "visible" - 19:56:56 INFO - 576 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | No stylesheets that were expected are missing - 0 == 0 - 19:56:56 INFO - 577 INFO canceling the dialog 19:56:56 INFO - 578 INFO waiting for dialogclosing 19:56:56 INFO - Buffered messages logged at 19:56:56 19:56:56 INFO - 579 INFO waiting for about:blank load 19:56:56 INFO - 580 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | overlay is not visible - "hidden" != "visible" - 19:56:56 INFO - 581 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | inline styles should be cleared - "" == "" - 19:56:56 INFO - Buffered messages finished 19:56:56 ERROR - 582 INFO TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_subdialogs.js | sub-dialog should be unloaded - "chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/subdialog.xul" == "about:blank" - 19:56:56 INFO - Stack trace: 19:56:56 INFO - resource://testing-common/content-task.js line 52 > eval:null:20 19:56:56 INFO - 583 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | closing event should indicate button was 'null' - null == null - 19:56:56 INFO - 584 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | should be 1 if accepted, 0 if canceled, undefined if closed w/out button - "undefined" == "undefined" - 19:56:56 INFO - 585 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | dialog count should decrease by 1 - 0 == 0 - 19:56:56 INFO - 586 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | stack children count should decrease by 1 - 1 == 1 - 19:56:56 INFO - 587 INFO Leaving test bound back_navigation_on_browser_tab_should_close_dialog 19:56:56 INFO - 588 INFO Entering test bound escape_should_close_dialog 19:56:56 INFO - GECKO(7944) | ++DOCSHELL 00000223B4263800 == 26 [pid = 7944] [id = {e649601e-4e0f-44bf-b01d-8ad81ed9e9c2}] 19:56:56 INFO - GECKO(7944) | ++DOMWINDOW == 112 (00000223B47B2370) [pid = 7944] [serial = 1814] [outer = 0000000000000000] 19:56:56 INFO - GECKO(7944) | ++DOMWINDOW == 113 (00000223B3156800) [pid = 7944] [serial = 1815] [outer = 00000223B47B2370] 19:56:56 INFO - GECKO(7944) | ++DOMWINDOW == 114 (00000223BC346000) [pid = 7944] [serial = 1816] [outer = 00000223B47B2370] 19:56:56 INFO - 589 INFO waiting for subdialog DOMFrameContentLoaded 19:56:56 INFO - GECKO(7944) | ++DOMWINDOW == 115 (00000223AF33B800) [pid = 7944] [serial = 1817] [outer = 00000223AF0DB200] 19:56:56 INFO - 590 INFO waiting for subdialog load 19:56:57 INFO - 591 INFO subdialog window is loaded 19:56:57 INFO - 592 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | The dialog should be non-null - true == true - 19:56:57 INFO - 593 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | Subdialog URL should not be about:blank - "chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/subdialog.xul" != "about:blank" - 19:56:57 INFO - 594 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | Overlay should be visible - "visible" == "visible" - 19:56:57 INFO - 595 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | No stylesheets that were expected are missing - 0 == 0 - 19:56:57 INFO - 596 INFO canceling the dialog 19:56:57 INFO - 597 INFO waiting for dialogclosing 19:56:57 INFO - 598 INFO waiting for about:blank load
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 8 years ago → 7 years ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171140279&repo=mozilla-central&lineNumber=12215
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=184675946&repo=autoland&lineNumber=6689 611 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | overlay is not visible - "hidden" != "visible" - 11:31:48 INFO - 612 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | inline styles should be cleared - "" == "" - 11:31:48 INFO - Buffered messages finished 11:31:48 ERROR - 613 INFO TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_subdialogs.js | sub-dialog should be unloaded - "chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/subdialog.xul" == "about:blank" - 11:31:48 INFO - Stack trace: 11:31:48 INFO - resource://testing-common/content-task.js line 59 > eval:null:20 11:31:48 INFO - 614 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | closing event should indicate button was 'null' - null == null - 11:31:48 INFO - 615 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | should be 1 if accepted, 0 if canceled, undefined if closed w/out button - "undefined" == "undefined" - 11:31:48 INFO - 616 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | dialog count should decrease by 1 - 0 == 0 - 11:31:48 INFO - 617 INFO TEST-PASS | browser/components/preferences/in-content/tests/browser_subdialogs.js | stack children count should decrease by 1 - 1 == 1 - 11:31:48 INFO - 618 INFO Leaving test bound back_navigation_on_subdialog_should_close_dialog
Status: RESOLVED → REOPENED
Flags: needinfo?(jaws)
Resolution: INCOMPLETE → ---
Assignee: nobody → jaws
Status: REOPENED → ASSIGNED
Flags: needinfo?(jaws)
The previous five failure notices all detailed failures that occurred when the back button was used to close the dialog (back_navigation_on_subdialog_should_close_dialog or back_navigation_on_browser_tab_should_close_dialog).
Comment on attachment 8993078 [details] Bug 1371142 - Confirm that the page loaded is about:blank before continuing with the test. https://reviewboard.mozilla.org/r/257902/#review264856 ::: browser/components/preferences/in-content/tests/browser_subdialogs.js:82 (Diff revision 1) > let actualAcceptCount = frame.contentWindow.arguments && > frame.contentWindow.arguments[0].acceptCount; > > info("waiting for about:blank load"); > - await ContentTaskUtils.waitForEvent(frame, "load"); > + await ContentTaskUtils.waitForEvent(frame, "load", false, () => { > + return frame.contentWindow.location.href.toString() == "about:blank"; Do you really need the `.toString()` here? I don't think you should... location.href is already a string, right? ( https://searchfox.org/mozilla-central/source/dom/webidl/Location.webidl#24 )
Attachment #8993078 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e60e86dd8d8 Confirm that the page loaded is about:blank before continuing with the test. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/7e60e86dd8d8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: