Closed Bug 1371147 Opened 8 years ago Closed 7 years ago

PK11Store.getEncryptedPrivateKeyInfo() segfault if export fails

Categories

(JSS Graveyard :: Library, defect)

4.4.2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ftweedal, Assigned: ftweedal)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20170420084331 Steps to reproduce: Use PK11Store.getEncryptedPrivateKeyInfo() with Thales nethsm. Actual results: PK11_ExportEncryptedPrivKeyInfo returning NULL is not being handled properly, causing segfault. Expected results: Detect this condition and raise a TokenException instead.
Assignee: glenbeasley → ftweedal
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
cfu checked-in the following changes provided by ftweedal: changeset: 2204:87dca07f7529 tag: tip user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:56:04 2017 -0700 summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - changeset: 2203:b3b653faef84 user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:53:36 2017 -0700 summary: bug 1370778 PBE and padded block cipher enhancements and fixes - changeset: 2202:0b8a6e84b6c7 user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:50:21 2017 -0700 summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - changeset: 2201:d39e9b373798 user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:32:32 2017 -0700 summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - changeset: 2200:890216599f21 user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:21:22 2017 -0700 summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - changeset: 2199:bada1409d2bb user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:15:29 2017 -0700 summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - changeset: 2198:3629b598a9ce user: Fraser Tweedale<ftweedale@redhat.com> date: Fri Sep 08 11:09:23 2017 -0700 summary: Bug 1370778 PBE and padded block cipher enhancements and fixes -
(In reply to Matthew Harmsen from comment #1) > cfu checked-in the following changes provided by ftweedal: > > changeset: 2204:87dca07f7529 > tag: tip > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:56:04 2017 -0700 > summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - > > changeset: 2203:b3b653faef84 > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:53:36 2017 -0700 > summary: bug 1370778 PBE and padded block cipher enhancements and fixes - > > changeset: 2202:0b8a6e84b6c7 > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:50:21 2017 -0700 > summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - > > changeset: 2201:d39e9b373798 > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:32:32 2017 -0700 > summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - > > changeset: 2200:890216599f21 > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:21:22 2017 -0700 > summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - > > changeset: 2199:bada1409d2bb > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:15:29 2017 -0700 > summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - > > changeset: 2198:3629b598a9ce > user: Fraser Tweedale<ftweedale@redhat.com> > date: Fri Sep 08 11:09:23 2017 -0700 > summary: Bug 1370778 PBE and padded block cipher enhancements and fixes - INCORRECT MESSAGE -- These check-ins were for https://bugzilla.mozilla.org/show_bug.cgi?id=1370778
Comment on attachment 8875563 [details] [diff] [review] jss-ftweedal-0011-Don-t-crash-if-PK11_ExportEncryptedPrivKeyInfo-retur.patch Review of attachment 8875563 [details] [diff] [review]: ----------------------------------------------------------------- ACK
cfu checked-in ftweedal's patch: changeset: 2205:3e9a5ae2149d tag: tip user: Fraser Tweedale<ftweedale@redhat.com> date: Mon Sep 11 17:24:22 2017 -0700 summary: Bug 1371147 PK11Store.getEncryptedPrivateKeyInfo() segfault if export fails -
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: