Closed Bug 1371152 Opened 7 years ago Closed 4 years ago

Have the bugfiler try stripping junk from the failure line, and if it complains about not matching any search terms, just go back to the unstripped summary

Categories

(Tree Management :: Treeherder: Frontend, enhancement)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: philor, Unassigned)

Details

<KWierso|afk> I suppose I should have the filer try stripping and if it complains about not matching, just go back to the unstripped summary?
Component: Treeherder → Treeherder: Log Parsing & Classification
Assignee: kwierso → nobody
Barely comprehensible nine months later.

https://github.com/mozilla/treeherder/blob/b3d02f3874175d7be3d27608408fe665764d70d3/ui/js/controllers/bugfiler.js#L102 and some other bits nearby take a failure line like "TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/generic/crashtests/334148-1.xhtml | application terminated with exit code 4" and turn it into "Intermittent layout/generic/crashtests/334148-1.xhtml | application terminated with exit code 4" but sometimes that isn't a good idea, and we unhelpfully hit https://github.com/mozilla/treeherder/blob/b3d02f3874175d7be3d27608408fe665764d70d3/ui/js/controllers/bugfiler.js#L47 and tell the poor person trying to file that the bug summary won't match the search terms when the reason it doesn't match is that stripping out things bugfiler thought were junk actually broke a previously usable summary.
Summary: Have the bugfiler try stripping and if it complains about not matching, just go back to the unstripped summary → Have the bugfiler try stripping junk from the failure line, and if it complains about not matching any search terms, just go back to the unstripped summary

Closed for inaction.

Status: NEW → RESOLVED
Type: defect → enhancement
Closed: 4 years ago
Component: Treeherder: Log Parsing & Classification → Treeherder: Frontend
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.