If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Port SDP file parser to LibFuzzer

RESOLVED FIXED in Firefox 56

Status

()

Core
WebRTC: Signaling
P2
normal
Rank:
25
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 months ago
It looks like it should be possible to fuzz our beloved sipcc based SDP parser these days with LibFuzzer instead of using Peach.
(Assignee)

Updated

4 months ago
Rank: 25
Comment hidden (mozreview-request)
(Assignee)

Comment 2

4 months ago
The idea behind the old sdp_file_parser was to have a small executable to make fuzzing with Peach faster (compared to starting a Firefox binary).

From looking at some examples from LibFuzzer I think the attached patch is about what we need to accomplish the same now with LibFuzzer. But what I'm missing right now is how I would be able to build/link such an executable. Maybe I'm on the wrong path here and LibFuzzer always requires the fuzzing target to be a lib which the LibFuzzer executable can link in?

Any help/advice on this would be appreciated.
Flags: needinfo?(choller)
Flags: needinfo?(cdiehl)
Discussed this on IRC. This might be a good opportunity to try out the new unified fuzzing interface.
Flags: needinfo?(choller)
Flags: needinfo?(cdiehl)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8875576 - Attachment is obsolete: true
(Assignee)

Updated

3 months ago
Attachment #8876338 - Flags: review?(choller)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8876338 [details]
Bug 1371161: port SDP file parser to LibFuzzer

https://reviewboard.mozilla.org/r/147738/#review152630

Looks good, FUZZING only, r+ from me with nits

::: media/webrtc/signaling/fuzztest/sdp_parser_libfuzz.cpp:8
(Diff revision 1)
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include <string>
> -#include <iostream>
> +//#include <iostream>

Remove these if they are no longer needed
Attachment #8876338 - Flags: review?(choller) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

3 months ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/c902eebc0191
port SDP file parser to LibFuzzer r=decoder

Comment 9

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c902eebc0191
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.