Closed Bug 1371195 Opened 7 years ago Closed 7 years ago

Preserve Form Autofill profiles during a Firefox Refresh/Reset

Categories

(Firefox :: Migration, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- verified
firefox57 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [form autofill:MVP])

Attachments

(1 file)

Since we preserve form history data we should also preserve form autofill data as well.

We can add the file to `formData` at
https://dxr.mozilla.org/mozilla-central/rev/a49112c7a5765802096b3fc298069b9495436107/browser/components/migration/FirefoxProfileMigrator.js#130-142
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
Comment on attachment 8894005 [details]
Bug 1371195 - Preserve Form Autofill profiles during a Firefox Refresh/Reset.

https://reviewboard.mozilla.org/r/165074/#review170510

::: browser/components/migration/tests/marionette/test_refresh_firefox.py:119
(Diff revision 2)
> +            "address-level2": "Cambridge",
> +            "address-level1": "MA",
> +            "postal-code": "02139",
> +            country: "US",
> +            tel: "+16172535702",
> +            email: "timbl@w3.org",

I think we should probably use something other than Sir Tim's actual email address. :-)

::: browser/components/migration/tests/marionette/test_refresh_firefox.py:125
(Diff revision 2)
> +        if not self._formAutofillAddressGuid:
> +          print self._formAutofillAddressGuid

This only ever prints None or 0, right? That doesn't seem useful, maybe this is leftover debugging code? Should we remove it, or update it to be more descriptive?
Attachment #8894005 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8894005 [details]
Bug 1371195 - Preserve Form Autofill profiles during a Firefox Refresh/Reset.

https://reviewboard.mozilla.org/r/165074/#review170510

> I think we should probably use something other than Sir Tim's actual email address. :-)

Not that it makes it right but this was the example in the HTML spec[1] and we use it in our other tests. I also normally try to avoid using real domains/addresses/etc.

[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-autocomplete-email

> This only ever prints None or 0, right? That doesn't seem useful, maybe this is leftover debugging code? Should we remove it, or update it to be more descriptive?

I copied this from other similar methods in the file which seemed to imply that JS errors would be returned as strings so my understanding is that it would be useful to print exception info.
Comment on attachment 8894005 [details]
Bug 1371195 - Preserve Form Autofill profiles during a Firefox Refresh/Reset.

https://reviewboard.mozilla.org/r/165074/#review170510

> I copied this from other similar methods in the file which seemed to imply that JS errors would be returned as strings so my understanding is that it would be useful to print exception info.

Oh, I see what you mean that a string would be truthy
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/486a016bb177
Preserve Form Autofill profiles during a Firefox Refresh/Reset. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/486a016bb177
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Depends on: 1389999
Comment on attachment 8894005 [details]
Bug 1371195 - Preserve Form Autofill profiles during a Firefox Refresh/Reset.

Approval Request Comment
[Feature/Bug causing the regression]: Form autofill
[User impact if declined]: Autofill profiles won't be preserved with a Firefox Refresh/Reset i.e. data loss
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: simple list addition
[String changes made/needed]: None
Attachment #8894005 - Flags: approval-mozilla-beta?
Comment on attachment 8894005 [details]
Bug 1371195 - Preserve Form Autofill profiles during a Firefox Refresh/Reset.

Form autofill is enabled in Beta56 and this also includes test. Beta56+.
Attachment #8894005 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Reproduced the issues using an old Nightly from 2017-08-07 on macOS 10.12.6, verified that using Firefox 56 beta 11 across platforms (Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 32bit) the address autofill profiles are successfully preserved after a Firefox Refresh.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.