Closed
Bug 1371200
Opened 7 years ago
Closed 7 years ago
Add a structure so it is easier to pass more data to the MediaDecoder constructor
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(5 files)
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
cpearce
:
review+
|
Details |
1. we want to avoid 2-stage initialization whenever possible. 2. it is easier to add new data to the constructor without modifying each constructor of its sub-classes.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8875619 -
Flags: review?(cpearce)
Attachment #8875620 -
Flags: review?(cpearce)
Attachment #8875621 -
Flags: review?(cpearce)
Attachment #8875622 -
Flags: review?(cpearce)
Attachment #8875623 -
Flags: review?(cpearce)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8875620 [details] Bug 1371200. P2 - add more fields to MediaDecoderInit. https://reviewboard.mozilla.org/r/147038/#review152182 ::: dom/html/HTMLMediaElement.cpp:2469 (Diff revision 1) > SetupSrcMediaStreamPlayback(stream); > return NS_OK; > } > > if (mMediaSource) { > - MediaDecoderInit decoderInit(this); > + MediaDecoderInit decoderInit( You've written identical code to call MediaDecoderInit's constructor three times; it could be in a helper function.
Attachment #8875620 -
Flags: review?(cpearce) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8875619 [details] Bug 1371200. P1 - add MediaDecoderInit and fix MediaDecoder constructor and its friends. https://reviewboard.mozilla.org/r/147036/#review152184
Attachment #8875619 -
Flags: review?(cpearce) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8875621 [details] Bug 1371200. P3 - remove unused code. https://reviewboard.mozilla.org/r/147040/#review152186
Attachment #8875621 -
Flags: review?(cpearce) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8875622 [details] Bug 1371200. P4 - constify some members. https://reviewboard.mozilla.org/r/147042/#review152188
Attachment #8875622 -
Flags: review?(cpearce) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8875623 [details] Bug 1371200. P5 - devirtualize some functions that don't have overrides. https://reviewboard.mozilla.org/r/147044/#review152190
Attachment #8875623 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 11•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8875620 [details] Bug 1371200. P2 - add more fields to MediaDecoderInit. https://reviewboard.mozilla.org/r/147038/#review152182 > You've written identical code to call MediaDecoderInit's constructor three times; it could be in a helper function. We will have different initializations for InitializeDecoderAsClone() and InitializeDecoderForChannel() soon. So I don't bother to extract the common code here.
Assignee | ||
Comment 12•7 years ago
|
||
Thanks for the review!
Comment 13•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a12048e898ee P1 - add MediaDecoderInit and fix MediaDecoder constructor and its friends. r=cpearce https://hg.mozilla.org/integration/autoland/rev/dca576ac7065 P2 - add more fields to MediaDecoderInit. r=cpearce https://hg.mozilla.org/integration/autoland/rev/4a76d18a41c6 P3 - remove unused code. r=cpearce https://hg.mozilla.org/integration/autoland/rev/d2fd192ad927 P4 - constify some members. r=cpearce https://hg.mozilla.org/integration/autoland/rev/9858be1746b6 P5 - devirtualize some functions that don't have overrides. r=cpearce
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a12048e898ee https://hg.mozilla.org/mozilla-central/rev/dca576ac7065 https://hg.mozilla.org/mozilla-central/rev/4a76d18a41c6 https://hg.mozilla.org/mozilla-central/rev/d2fd192ad927 https://hg.mozilla.org/mozilla-central/rev/9858be1746b6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•