1371217 - Top Sites, Bookmarks & History are not centered

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P3)

Description

[Bogdan Surd, QA [:bsurd, NI]]

Attachment: portrait.jpg

Devices:  
 - Xiaomi Mi Pad 2 (Android 5.1);
 - Lenovo Yoga Tablet 2 (Android 4.4.2);
 - Nexus 5 (Android 6.0.1).


Steps to reproduce:
1. Open Fennec; 
2. Go to about:home.

Expected result:
 Top Sites, Bookmarks & History panels are centered.

Actual result:
 Top Sites, Bookmarks & History panels are not centered.

Notes:
 The issue is reproducible on all devices not just the ones listed above.

Comment 1

[Bogdan Surd, QA [:bsurd, NI]]

Attachment: landscape.jpg

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Please help prioritize this

Comment 3

[Wesly Huang (EPM)]

a good first bug should be fine

Comment 4

[mariahajmal]

I am an outreachy applicant. Can I work on this?

Comment 5

[Anca Manu]

Attachment: Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:anca.manu, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4eaea9067bae
Top Sites, Bookmarks & History are not centered; r=AndreiLazar

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4eaea9067bae

Comment 9

[Chris Peterson [:cpeterson]]

Hi Anca, can you please request uplift for your patch to Fennec 68 Beta? Fennec 68 will be maintained in the ESR 68 channel until mid-2020, so it would be good to have your fix in there. :)

Comment 10

[Anca Manu]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

Beta/Release Uplift Approval Request

• User impact if declined: The users will not be able to see the Sites, Bookmarks and History centered.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps to reproduce:

1. Open Fennec;
2. Go to about:home.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are not risky because we did only some small changes, such as centered the Sites, Bookmarks and History
• String changes made/needed: No strings were added.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

fennec ui fix, approved for 68.0b9

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6fc2a5a92f2

Comment 13

[Stefan Deiac]

Verified as fixed on Nightly 68.0a1 (2019-06-05) using Samsung Galaxy S8 (Android 9) and Nokia 6 (Android 7.1.1). I'll let the qe-verify + till the verification on Beta, thanks.

Comment 14

[Daniel Varga [:dvarga]]

Backed out changeset d6fc2a5a92f2 (Bug 1371217) from beta on suspicion of causing Bug 1557661.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Petru, maybe you can help here? We're getting close to RC week for 68.

Comment 16

[Stefan Deiac]

Verified as fixed on the latest Nightly 69.0a1 (2019-06-20).
Devices:

• Nokia 6 (Android 7.1.1);
• Samsung Galaxy Tab S3 (Android 8.0);
• Xiaomi Mi 8 Lite (Android 8.1).

Also, confirming that the issue is reproducible on the Beta 68.0b11 due to comment 14.

Comment 17

[Petru-Mugurel Lingurar [:petru]]

Andrei will resolve the remaining issue in bug 1557661
Removing my NI

Comment 18

[Andrei Lazar]

Since I fixed the regression, can we uplift both of these tickets?

Comment 19

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We should probably postpone uplift until after ESR 68 is branched because this is just a UI layout issue we've had for years.

Comment 20

[Julien Cristau [:jcristau]]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

see comment 10

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

Fixes a Fennec UI bug. Approved for Fennec 68.1b1.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

Whoops, bug 1557661 doesn't have an approval request yet. Putting this back in the queue so both land together.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

Take two, approved for 68.1b2! This will also be in tomorrow's Nightly builds if QA wants to get a jump start on verifying.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/2e991f40e3a8

Comment 25

[Eliza Balazs]

Hi!
Verified as fixed on the latest version of Nightly 68.1a1 (2019-07-10) with the following devices:

• Huawei MediaPad M2 (Android 5.1.1; Tablet);
• HTC Desire 820 (Android 6.0.1);
• Huawei Honor 8 (Android 7.0);
• Motorola Nexus 6 (Android 7.1.1);
• Samsung Galaxy Tab S3 (Android 8.0; Tablet).
  We will add the verify flag after we test this on Fennec ESR 68.1b2.

Comment 26

[Diana Rus]

Hi, verified on Fennec ESR 68.1b2 with devices:

• Sony Xperia Z3 (Android 5.1.1)
• Google Pixel 3aXL (Android 9)
• Samsung Galaxy S9 (Android 8.0.0)
• Sony Xperia Z5 (Android 7.0)