Top Sites, Bookmarks & History are not centered

RESOLVED FIXED in Firefox 69

Status

()

defect
P3
normal
RESOLVED FIXED
2 years ago
7 days ago

People

(Reporter: bsurd, Assigned: anca.manu, NeedInfo)

Tracking

(Regressed 1 bug, {good-first-bug})

Trunk
Firefox 69
ARM
Android
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(fennec+, firefox54 wontfix, firefox55 wontfix, firefox56 wontfix, firefox57 wontfix, firefox58 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox67 wontfix, firefox67.0.5 wontfix, firefox68 affected, firefox69 fixed)

Details

Attachments

(3 attachments)

Reporter

Description

2 years ago
Posted image portrait.jpg
Devices:  
 - Xiaomi Mi Pad 2 (Android 5.1);
 - Lenovo Yoga Tablet 2 (Android 4.4.2);
 - Nexus 5 (Android 6.0.1).


Steps to reproduce:
1. Open Fennec; 
2. Go to about:home.

Expected result:
 Top Sites, Bookmarks & History panels are centered.

Actual result:
 Top Sites, Bookmarks & History panels are not centered.

Notes:
 The issue is reproducible on all devices not just the ones listed above.
Reporter

Comment 1

2 years ago
Posted image landscape.jpg
tracking-fennec: --- → ?
Please help prioritize this
Assignee: nobody → cnevinchen
tracking-fennec: ? → +
Flags: needinfo?(wehuang)
Assignee: cnevinchen → nobody
Keywords: good-first-bug

Comment 3

2 years ago
a good first bug should be fine
Flags: needinfo?(wehuang)
Priority: -- → P3

Comment 4

4 months ago

I am an outreachy applicant. Can I work on this?

Assignee

Updated

2 months ago
Assignee: nobody → anca.manu
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:anca.manu, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(anca.manu)

Updated

17 days ago
Keywords: checkin-needed

Updated

17 days ago
Flags: needinfo?(anca.manu)

Comment 7

17 days ago

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4eaea9067bae
Top Sites, Bookmarks & History are not centered; r=AndreiLazar

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 17 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Hi Anca, can you please request uplift for your patch to Fennec 68 Beta? Fennec 68 will be maintained in the ESR 68 channel until mid-2020, so it would be good to have your fix in there. :)

Assignee

Comment 10

13 days ago

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

Beta/Release Uplift Approval Request

  • User impact if declined: The users will not be able to see the Sites, Bookmarks and History centered.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Steps to reproduce:
  1. Open Fennec;
  2. Go to about:home.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The changes are not risky because we did only some small changes, such as centered the Sites, Bookmarks and History
  • String changes made/needed: No strings were added.
Flags: needinfo?(anca.manu)
Attachment #9060709 - Flags: approval-mozilla-beta?
Assignee

Updated

13 days ago
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9060709 [details]
Bug 1371217 - Top Sites, Bookmarks & History are not centered; r?AndreiLazar

fennec ui fix, approved for 68.0b9

Attachment #9060709 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 13

11 days ago

Verified as fixed on Nightly 68.0a1 (2019-06-05) using Samsung Galaxy S8 (Android 9) and Nokia 6 (Android 7.1.1). I'll let the qe-verify + till the verification on Beta, thanks.

Regressions: 1557661

Backed out changeset d6fc2a5a92f2 (Bug 1371217) from beta on suspicion of causing Bug 1557661.

Flags: needinfo?(anca.manu)
Attachment #9060709 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.