Closed Bug 1371258 Opened 7 years ago Closed 7 years ago

Enable filtering of snippets based on vertical screen resolution on about:home

Categories

(Snippets :: Service, enhancement)

Product:
Snippets
Component:
Service
Platform:
All
Unspecified
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: giorgos, Assigned: giorgos)

References

Details

User Story

I would like to be able to display snippets to users based on their vertical screen pixels in order to provide useful information to users based features that may be of value to them (eg. compact themes).

Acceptance Criteria:
- Snippets are only displayed to users based on the vertical pixel count targeting used
-- Examples:
---1. Display snippet to users who have fewer than 1000 vertical pixels on their screen
---2. Display snippet to users who have at least 800 vertical pixels on their screen, but fewer than 1024
      No description provided.
Extend snippets service to allowing filtering by screen resolution.
User Story: (updated)
User story as of June 8th:

Acceptance Criteria:
- Snippets are only displayed to users based on the vertical pixel count targeting used
-- Examples:
---1. Display snippet to users who have fewer than 1000 vertical pixels on their screen
---2. Display snippet to users who have at least 800 vertical pixels on their screen, but fewer than 1024


Suggested implementation:

A list of 3 checkboxes

 - 1024 pixels or less (low)
 - more than 1024 and less than 1920 (hd)
 - more than 1920 (full hd, 4k, etc)


By default new snippets will have all checkboxes checked, i.e. display on all screens.

Jean does this work for you?
Flags: needinfo?(jcollings)
This works for me, thanks Giorgos!
Flags: needinfo?(jcollings)
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozmar/snippets-service

https://github.com/mozmar/snippets-service/commit/6e0790c35420df4a7ac0a0a11da1b523eabe61b9
[fix bug 1371258] Filter snippets based on vertical screen resolution.

https://github.com/mozmar/snippets-service/commit/0081d7417346b0811fcfc1727942b3b12703f036
Merge pull request #236 from glogiotatidis/resolution

[fix bug 1371258] Filter snippets based on vertical screen resolution.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Now in production \o/
You need to log in before you can comment on or make changes to this bug.