1371290 - YouTube video playback is jittering/micro-stuttering (Part 2)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

VP9 playback when HW decoding is enabled is jittery.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1371290: P1. Use TimeUnit in WMF decoder.

Using a float to store the last duration was unwise (as it has only a 24 bits mantissa), luckily it wasn't used except very particular circumstances.

Review commit: https://reviewboard.mozilla.org/r/147158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147158/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1371290: P2. Override sample duration if unknown.

The VP9 decoder doesn't properly set the sample duration, leading to all samples being marked as having a zero duration.

The compositor drops those frames incorrectly. This issue will be addressed in bug 1222874.

Review commit: https://reviewboard.mozilla.org/r/147160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147160/

Comment 3

[Jean-Yves Avenard [:jya]]

[Tracking Requested - why for this release]:

Comment 4

[Jean-Yves Avenard [:jya]]

[Tracking Requested - why for this release]: the bug put us at a serious disadvantage over Edge and Chrome on new machines. Where they would barely use any CPU where we would take lots and use much more batteries.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8875733 [details]
Bug 1371290: P1. Use TimeUnit in WMF decoder.

https://reviewboard.mozilla.org/r/147158/#review151566

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8875734 [details]
Bug 1371290: P2. Override sample duration if unknown.

https://reviewboard.mozilla.org/r/147160/#review151568

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/381c3ee3d00e
P1. Use TimeUnit in WMF decoder. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/52586ef104b1
P2. Override sample duration if unknown. r=mattwoodrow

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/381c3ee3d00e
https://hg.mozilla.org/mozilla-central/rev/52586ef104b1

Comment 9

[Andrei Vaida [:avaida]]

Would manual testing be of value here?

Comment 10

[Jean-Yves Avenard [:jya]]

We've had confirmation in bug 1314458 that it did resolve the issue for users with those cards.

Comment 11

[Andrei Vaida [:avaida]]

(In reply to Jean-Yves Avenard [:jya] from comment #10)
> We've had confirmation in bug 1314458 that it did resolve the issue for
> users with those cards.

Awesome, thanks for following up!