Clean up various ESLint global definitions in config files across the tree

RESOLVED FIXED in Firefox 55

Status

Testing
Lint
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Version 3
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

9 months ago
There's a few places across the tree where globals are defined unnecessarily in .eslintrc.js files. We should tidy those up and switch to using importing of globals where necessary or environments as appropriate.

In a few places I've had to define both global & exported as simply defining something as global will say it isn't used (extensions/ has "all" no unused vars turned on). We should probably change our globals code at some stage to additionally use the exported indication, but lets leave that for another bug.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8875737 [details]
Bug 1371292 - Clean up more ESLint global definitions in configuration files in toolkit/ and browser/.

https://reviewboard.mozilla.org/r/147164/#review151524
Attachment #8875737 - Flags: review?(dtownsend) → review+

Comment 4

9 months ago
mozreview-review
Comment on attachment 8875738 [details]
Bug 1371292 - Clean up more ESLint global definitions in configuration files in mobile/android.

https://reviewboard.mozilla.org/r/147166/#review151532
Attachment #8875738 - Flags: review?(dtownsend) → review+

Comment 5

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27f5231ba905
Clean up more ESLint global definitions in configuration files in toolkit/ and browser/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/4ed96242e485
Clean up more ESLint global definitions in configuration files in mobile/android. r=mossop

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/27f5231ba905
https://hg.mozilla.org/mozilla-central/rev/4ed96242e485
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.