Closed
Bug 1371317
Opened 8 years ago
Closed 8 years ago
ARM simulator: don't trigger an interrupt if the simulator is already interrupted
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
This happened while trying to debug bug 1371138, when running the test under rr. The regular non-simulator code does the already-interrupted check, but the simulator does not; that's easy to fix, pretty hard to test.
|
Assignee | |
Comment 1•8 years ago
|
||
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8875778 [details] [diff] [review]
fix.patch
Review of attachment 8875778 [details] [diff] [review]:
-----------------------------------------------------------------
What about instead removing the assert from trigger_wasm_interrupt()?
Attachment #8875778 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
I liked the symmetry between real code / simulator code, but removing the assert is strictly less code. I'll do this and add a comment stating it's not harmful to keep it that way. Thanks for the quick review!
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d07706eb18a
ARM simulator: don't assert when triggering a second interrupt; r=luke
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•