Closed Bug 1371345 Opened 7 years ago Closed 7 years ago

Deadlock in mscom::Interceptor::~Interceptor

Categories

(Core :: Disability Access APIs, enhancement)

Product:
Core
Component:
Disability Access APIs
Platform:
Unspecified
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file, 3 obsolete files)

Release live set lock before posting work to main thread (r4)
10.69 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
This happens when GetInitialInterceptorForIID has to fallback and call GetInterceptorForIID(). The latter function needs to run some stuff on the main thread, so we should release the live set lock before doing that.
Some minor cleanup, basically the same patch
Attachment #8875811 - Attachment is obsolete: true
Attachment #8875811 - Flags: review?(jmathies)
Attachment #8875812 - Flags: review?(jmathies)
Pretty silly of me to write an AutoLock class that doesn't... umm... lock! ;-)
Attachment #8875812 - Attachment is obsolete: true
Attachment #8875812 - Flags: review?(jmathies)
Attachment #8875890 - Flags: review?(jmathies)
I missed another location where main thread activity could occur. I had to add a new function to weak reference support so that I could separate locking a strong ref from doing a subsequent QI on that strong ref.
Attachment #8875890 - Attachment is obsolete: true
Attachment #8875890 - Flags: review?(jmathies)
Attachment #8875909 - Flags: review?(jmathies)
Comment on attachment 8875909 [details] [diff] [review]
Release live set lock before posting work to main thread (r4)

Review of attachment 8875909 [details] [diff] [review]:
-----------------------------------------------------------------

been testing with this, lock up appears fixed.
Attachment #8875909 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/acbfbde0a7d20e741a347e121c0a34aa938a474a
Bug 1371345: Fix deadlock caused by holding mscom Interceptor live set lock while posting work to the main thread; r=jimm
https://hg.mozilla.org/mozilla-central/rev/acbfbde0a7d2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: