1371374 - [nb-NO][nn-NO][Desktop] Searchplugin for Bokmålsordboka | Nynorskordboka is broken

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Håvar I. Henriksen [:havarh]]

The searchplugin bok-NO.xml is broken because the site has been moved from nob-ordbok.uio.no to ordbok.uib.no.
Another university has taken over the responsibility for this project.
This only affects desktop, since this search provider is not available on mobile.

Comment 1

[Håvar I. Henriksen [:havarh]]

Attachment: bok-NO.diff

Fixed searchplugin

Comment 2

[Francesco Lodolo [:flod]]

Thanks Håvar for the report. On second thoughts, I'm going to take over the bug and use your patch as a starting point since it doesn't apply to the repo

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1371374 - Use new domain for Norwegian searchplugin bok-NO.xml

Review commit: https://reviewboard.mozilla.org/r/147248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147248/

Comment 4

[Francesco Lodolo [:flod]]

Tested, and utf-8 works fine.
https://l10n.mozilla-community.org/~flod/testsp/

I tried to search for an updated icon, but the website's favicon is only 16px, and the Apple icons they're using a quite different. Priority is to fix the domain at this point.

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 8875840 [details]
Bug 1371374 - Use new domain for Norwegian searchplugin bok-NO.xml

https://reviewboard.mozilla.org/r/147248/#review151468

Has this really been broken since Sept 2016 (per the old webpage?)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23c65a593b7d
Use new domain for Norwegian searchplugin bok-NO.xml r=mkaply

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #5)
> Has this really been broken since Sept 2016 (per the old webpage?)

That's a good question. Håvar, any idea?

Truth is that I found several broken searchplugins in the past years by running a script that checks if the searchform doesn't go 404, but it wouldn't catch cases like this one.

Comment 8

[Håvar I. Henriksen [:havarh]]

(In reply to Francesco Lodolo [:flod] from comment #7)
> (In reply to Mike Kaply [:mkaply] from comment #5)
> > Has this really been broken since Sept 2016 (per the old webpage?)
> 
> That's a good question. Håvar, any idea?
> 
Yes, it seems like that. Unfortunately.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23c65a593b7d