Closed Bug 1371374 Opened 5 years ago Closed 5 years ago

[nb-NO][nn-NO][Desktop] Searchplugin for Bokmålsordboka | Nynorskordboka is broken

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: havarh, Assigned: flod)

Details

Attachments

(1 file, 1 obsolete file)

The searchplugin bok-NO.xml is broken because the site has been moved from nob-ordbok.uio.no to ordbok.uib.no.
Another university has taken over the responsibility for this project.
This only affects desktop, since this search provider is not available on mobile.
Attached patch bok-NO.diff (obsolete) — Splinter Review
Fixed searchplugin
Assignee: nobody → havar
Attachment #8875832 - Flags: review?(francesco.lodolo)
Thanks Håvar for the report. On second thoughts, I'm going to take over the bug and use your patch as a starting point since it doesn't apply to the repo
Assignee: havar → francesco.lodolo
Attachment #8875832 - Attachment is obsolete: true
Attachment #8875832 - Flags: review?(francesco.lodolo)
Tested, and utf-8 works fine.
https://l10n.mozilla-community.org/~flod/testsp/

I tried to search for an updated icon, but the website's favicon is only 16px, and the Apple icons they're using a quite different. Priority is to fix the domain at this point.
Comment on attachment 8875840 [details]
Bug 1371374 - Use new domain for Norwegian searchplugin bok-NO.xml

https://reviewboard.mozilla.org/r/147248/#review151468

Has this really been broken since Sept 2016 (per the old webpage?)
Attachment #8875840 - Flags: review?(mozilla) → review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/23c65a593b7d
Use new domain for Norwegian searchplugin bok-NO.xml r=mkaply
(In reply to Mike Kaply [:mkaply] from comment #5)
> Has this really been broken since Sept 2016 (per the old webpage?)

That's a good question. Håvar, any idea?

Truth is that I found several broken searchplugins in the past years by running a script that checks if the searchform doesn't go 404, but it wouldn't catch cases like this one.
(In reply to Francesco Lodolo [:flod] from comment #7)
> (In reply to Mike Kaply [:mkaply] from comment #5)
> > Has this really been broken since Sept 2016 (per the old webpage?)
> 
> That's a good question. Håvar, any idea?
> 
Yes, it seems like that. Unfortunately.
https://hg.mozilla.org/mozilla-central/rev/23c65a593b7d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.