Closed Bug 1371376 Opened 7 years ago Closed 7 years ago

Improvements to mscom smart pointers

Categories

(Core :: Disability Access APIs, enhancement)

Unspecified
Windows
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

It occurred to me that the mscom smart pointers are not as performant as they could be, because EnsureMTA always executes work on the MTA thread synchronously.

A destruction operation doesn't really need to be synchronous, so we should make EnsureMTA support asynchronous operations and modify the mscom smart pointers to use it.
Attached patch Make mscom MTA deleters async (obsolete) — Splinter Review
This patch also adds a new pointer type that does a delete in the MTA instead of a Release().
Attachment #8875857 - Flags: review?(jmathies)
Attachment #8875857 - Attachment is obsolete: true
Attachment #8875857 - Flags: review?(jmathies)
Attachment #8875862 - Flags: review?(jmathies)
Attachment #8875862 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/3fea90e94f1d
https://hg.mozilla.org/mozilla-central/rev/ee6c97bf9ca6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: