1371382 - Bump vendored gl_generator to 0.5.3

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

We have gl_generator 0.5.2 in our Cargo.lock and vendored in-tree:
http://searchfox.org/mozilla-central/rev/1a054419976437d0778a2b89be1b00207a744e94/toolkit/library/rust/Cargo.lock#364

I fixed an issue in gl_generator recently to make its output deterministic, which was making sccache unable to cache all crates downstream of it in the dependency graph:
https://github.com/brendanzab/gl-rs/pull/415

I submitted PRs to Webrender and Servo to update, but we still have 0.5.2 in Gecko currently. We should fix that so quantum-render builds can use sccache effectively.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1371382 - Update gl_generator to 0.5.3.

This also pulls in khronos_api v1.0.1

Review commit: https://reviewboard.mozilla.org/r/147290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147290/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8875899 [details]
Bug 1371382 - Update gl_generator to 0.5.3.

https://reviewboard.mozilla.org/r/147290/#review151544

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b72abe64ab7
Update gl_generator to 0.5.3. r=jrmuizel

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b72abe64ab7

Comment 5

[(not currently active) Ted Mielczarek]

Thanks! I had forgotten that we had made webrender build-by-default, so this is probably why my Rust sccache patches weren't showing as much improvement as I had hoped.