Bump vendored gl_generator to 0.5.3

RESOLVED FIXED in Firefox 55

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: ted, Assigned: kats)

Tracking

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

We have gl_generator 0.5.2 in our Cargo.lock and vendored in-tree:
http://searchfox.org/mozilla-central/rev/1a054419976437d0778a2b89be1b00207a744e94/toolkit/library/rust/Cargo.lock#364

I fixed an issue in gl_generator recently to make its output deterministic, which was making sccache unable to cache all crates downstream of it in the dependency graph:
https://github.com/brendanzab/gl-rs/pull/415

I submitted PRs to Webrender and Servo to update, but we still have 0.5.2 in Gecko currently. We should fix that so quantum-render builds can use sccache effectively.
Assignee: nobody → bugmail
Comment on attachment 8875899 [details]
Bug 1371382 - Update gl_generator to 0.5.3.

https://reviewboard.mozilla.org/r/147290/#review151544
Attachment #8875899 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b72abe64ab7
Update gl_generator to 0.5.3. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/5b72abe64ab7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Thanks! I had forgotten that we had made webrender build-by-default, so this is probably why my Rust sccache patches weren't showing as much improvement as I had hoped.
Blocks: 1357825
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.