Closed Bug 1371434 Opened 7 years ago Closed 7 years ago

GLX: Use the proper values when asking for a core context

Categories

(Core :: Graphics, enhancement)

Product:
Core
Component:
Graphics
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

Use LOCAL_GLX_CONTEXT_PROFILE_MASK_ARB instead of LOCAL_GLX_CONTEXT_FLAGS_ARB
771 bytes, patch
jgilbert
: review+
kvark
: review+
Details | Diff | Splinter Review 
      No description provided.
I'm not sure why I originally used GLX_CONTEXT_FLAGS_ARB but the spec at https://www.khronos.org/registry/OpenGL/extensions/ARB/GLX_ARB_create_context.txt strongly suggests using GLX_CONTEXT_PROFILE_MASK_ARB
Assignee: nobody → jmuizelaar
Attachment #8875900 - Flags: review?(jgilbert)
Blocks: 1371431
Attachment #8875900 - Flags: review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b172475e101c
Use LOCAL_GLX_CONTEXT_PROFILE_MASK_ARB instead of LOCAL_GLX_CONTEXT_FLAGS_ARB. r=kvark
Attachment #8875900 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/b172475e101c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: