Closed Bug 1371485 Opened 2 years ago Closed Last year

Upgrade to GYP that supports VS2017

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: gps, Assigned: dminor)

References

Details

Attachments

(8 files)

Fallout from bug 1371465. Not really a blocker to vs2017. But worth tracking.
Maybe we should import an independent copy of gyp, rather than whatever comes with webrtc.
I would support this. But only if we nuke WebRTC's duplicate copy in the process: I don't like redundant copies of things in source control.
Sure.  And WebRTC needs to move away from Gyp very soon (next import) to GN (BUILD.gn files).  the 57 import I'm about to land next week required me to un-delete and update the old, removed gyp files in upstream.
Greg, I could take this on as part of cleaning up the webrtc build. Do you have a location in mind for where gyp should live?
Flags: needinfo?(gps)
I think `python/gyp` would probably be fine.
We have third_party/python now. It should live there.
Flags: needinfo?(gps)
Product: Core → Firefox Build System
I think the webrtc.org gtests are the only user of gflags in tree. We can switch
over to using gn to build this when we start building the tests using gn,
which is Bug 1430779.
We're currently returning a fake value on all of our automation builds. Might
as well not run the script at all.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Comment on attachment 8987515 [details]
Bug 1371485 - Remove webrtc copy of gyp

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D1798
Attachment #8987515 - Flags: review+
Comment on attachment 8987516 [details]
Bug 1371485 - Remove unnecessary gyp files from webrtc

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D1799
Attachment #8987516 - Flags: review+
Comment on attachment 8987517 [details]
Bug 1371485 - Update gyp to 4d467626b0b9f59a85fb81ca4d7ea9eca99b9d8f

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D1800
Attachment #8987517 - Flags: review+
Comment on attachment 8987518 [details]
Bug 1371485 - Use updated version of gyp

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D1801
Attachment #8987518 - Flags: review+
Comment on attachment 8987519 [details]
Bug 1371485 - Fix gflags root

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D1802
Attachment #8987519 - Flags: review+
Comment on attachment 8987520 [details]
Bug 1371485 - Remove OS X find_sdk.py check

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D1803
Attachment #8987520 - Flags: review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b604564918d
Remove webrtc copy of gyp; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/da14dc867e22
Remove unnecessary gyp files from webrtc; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/17fc0da77821
Update gyp to 4d467626b0b9f59a85fb81ca4d7ea9eca99b9d8f; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/c205b5921de8
Use updated version of gyp; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/36bca079ba29
Fix gflags root; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/9578824cbdde
Remove OS X find_sdk.py check; r=chmanchester
Looks like a gcc internal compiler error:

[task 2018-06-27T17:14:58.391Z] 17:14:58     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -m32 -march=pentium-m -o Unified_cpp_js_src20.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_SIMD -DENABLE_WASM_BULKMEM_OPS -DENABLE_WASM_SATURATING_TRUNC_OPS -DENABLE_WASM_THREAD_OPS -DENABLE_WASM_GC -DJS_CACHEIR_SPEW -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES '-DDLL_PREFIX="lib"' '-DDLL_SUFFIX=".so"' -DFFI_BUILDING -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src/ctypes/libffi/include -I/builds/worker/workspace/build/src/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fno-omit-frame-pointer -Werror -Wno-shadow -Werror=format -fno-strict-aliasing -fprofile-use -fprofile-correction -Wcoverage-mismatch -MD -MP -MF .deps/Unified_cpp_js_src20.o.pp   /builds/worker/workspace/build/src/obj-firefox/js/src/Unified_cpp_js_src20.cpp
[task 2018-06-27T17:14:58.391Z] 17:14:58     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/js/src/Unified_cpp_js_src20.cpp:47:0:
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  /builds/worker/workspace/build/src/js/src/jit/Sink.cpp: In member function 'bool mozilla::Vector<T, N, AllocPolicy>::growStorageBy(size_t) [with T = js::jit::SafepointSlotEntry; unsigned int MinInlineCapacity = 0u; AllocPolicy = js::jit::JitAllocPolicy]':
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  /builds/worker/workspace/build/src/js/src/jit/Sink.cpp:232:1: internal compiler error: Segmentation fault
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -   } // namespace js
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -   ^
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0xb0221f crash_signal
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/toplev.c:333
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0x110e107 cancel_negative_cycle
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/mcf.c:889
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0x110e107 find_minimum_cost_flow
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/mcf.c:1349
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0x110e107 mcf_smooth_cfg()
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/mcf.c:1398
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0xa737bc compute_branch_probabilities
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/profile.c:721
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0xa737bc branch_prob()
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/profile.c:1301
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0xb9ae76 tree_profiling
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/tree-profile.c:536
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  0xb9ae76 execute
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  	../../gcc-6.4.0/gcc/tree-profile.c:638
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  Please submit a full bug report,
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  with preprocessed source if appropriate.
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  Please include the complete backtrace with any bug report.
[task 2018-06-27T17:14:58.397Z] 17:14:58     INFO -  See <http://gcc.gnu.org/bugs.html> for instructions.

Not sure why the gyp changes would have any effect on the spidermonkey build.
Flags: needinfo?(dminor)
Weird pgo bug, perhaps?  Is it an intermittent, or does it happen all the time?
Flags: needinfo?(apavel)
(In reply to Nathan Froyd [:froydnj] from comment #22)
> Weird pgo bug, perhaps?  Is it an intermittent, or does it happen all the
> time?

This build ran on that push, each retrigger failed, thus perma-failure. I can add it manually on previous or next pushes.
I'm sorry, I just noticed i pasted the wrong failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185203313&repo=mozilla-inbound&lineNumber=309 - this is the correct one.

[task 2018-06-27T16:50:17.681Z]  0:10.63 Downloaded artifact to /builds/worker/tooltool-cache/93c7c79b6a9964e3-rustc.tar.xz
[task 2018-06-27T16:50:17.686Z]  0:10.64 untarring "/builds/worker/workspace/breakpad-tools.tar.xz"
[task 2018-06-27T16:50:18.091Z]  0:11.04 untarring "/builds/worker/workspace/clang.tar.xz"
[task 2018-06-27T16:50:41.414Z]  0:34.37 untarring "/builds/worker/workspace/gcc.tar.xz"
[task 2018-06-27T16:50:57.430Z]  0:50.38 untarring "/builds/worker/workspace/rustc.tar.xz"
[task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin' '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
[task 2018-06-27T16:51:11.828Z] ++ export PATH=/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ PATH=/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin' '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
[task 2018-06-27T16:51:11.828Z] ++ export PATH=/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ PATH=/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin' '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
[task 2018-06-27T16:51:11.828Z] ++ export PATH=/builds/worker/workspace/rustc/bin:/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ PATH=/builds/worker/workspace/rustc/bin:/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin' '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
[task 2018-06-27T16:51:11.828Z] ++ export PATH=/builds/worker/workspace/VC/bin/Hostx64/x86:/builds/worker/workspace/rustc/bin:/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] ++ PATH=/builds/worker/workspace/VC/bin/Hostx64/x86:/builds/worker/workspace/rustc/bin:/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[task 2018-06-27T16:51:11.828Z] + mkdir -p /builds/worker/artifacts/
[task 2018-06-27T16:51:11.829Z] + AUTOMATION=1
[task 2018-06-27T16:51:11.829Z] + DIST=/builds/worker/artifacts/
[task 2018-06-27T16:51:11.829Z] + /builds/worker/workspace/build/src/js/src/make-source-package.sh
[task 2018-06-27T16:51:11.834Z] Environment:
[task 2018-06-27T16:51:11.834Z]     MAKE = 
[task 2018-06-27T16:51:11.834Z]     MKDIR = mkdir
[task 2018-06-27T16:51:11.834Z]     TAR = tar
[task 2018-06-27T16:51:11.834Z]     AUTOCONF = /usr/bin/autoconf2.13
[task 2018-06-27T16:51:11.834Z]     STAGING = /tmp/mozjs-src-pkg
[task 2018-06-27T16:51:11.834Z]     DIST = /builds/worker/artifacts/
[task 2018-06-27T16:51:11.834Z]     SRCDIR = /builds/worker/workspace/build/src/js/src
[task 2018-06-27T16:51:11.834Z]     MOZJS_NAME = mozjs
[task 2018-06-27T16:51:11.834Z]     MOZJS_MAJOR_VERSION = 63
[task 2018-06-27T16:51:11.834Z]     MOZJS_MINOR_VERSION = 0a1
[task 2018-06-27T16:51:11.834Z]     MOZJS_PATCH_VERSION = 
[task 2018-06-27T16:51:11.834Z]     MOZJS_ALPHA = 
[task 2018-06-27T16:51:11.834Z] 
[task 2018-06-27T16:51:11.834Z] Staging source tarball in /tmp/mozjs-src-pkg/mozjs-63.0a1.0...
[task 2018-06-27T16:51:14.346Z] cp: cannot stat `/builds/worker/workspace/build/src/js/src/../../media/webrtc/trunk/tools/gyp': No such file or directory
[taskcluster 2018-06-27 16:51:14.700Z] === Task Finished ===
[taskcluster 2018-06-27 16:51:14.795Z] Unsuccessful task run with exit code: 1 completed in 196.859 seconds
Flags: needinfo?(nfroyd)
Flags: needinfo?(dminor)
Flags: needinfo?(apavel)
(In reply to Andreea Pavel [:apavel] from comment #23)
> (In reply to Nathan Froyd [:froydnj] from comment #22)
> > Weird pgo bug, perhaps?  Is it an intermittent, or does it happen all the
> > time?
> 
> This build ran on that push, each retrigger failed, thus perma-failure. I
> can add it manually on previous or next pushes.
> I'm sorry, I just noticed i pasted the wrong failure log:
> https://treeherder.mozilla.org/logviewer.html#?job_id=185203313&repo=mozilla-
> inbound&lineNumber=309 - this is the correct one.
> 
> [task 2018-06-27T16:50:17.681Z]  0:10.63 Downloaded artifact to
> /builds/worker/tooltool-cache/93c7c79b6a9964e3-rustc.tar.xz
> [task 2018-06-27T16:50:17.686Z]  0:10.64 untarring
> "/builds/worker/workspace/breakpad-tools.tar.xz"
> [task 2018-06-27T16:50:18.091Z]  0:11.04 untarring
> "/builds/worker/workspace/clang.tar.xz"
> [task 2018-06-27T16:50:41.414Z]  0:34.37 untarring
> "/builds/worker/workspace/gcc.tar.xz"
> [task 2018-06-27T16:50:57.430Z]  0:50.38 untarring
> "/builds/worker/workspace/rustc.tar.xz"
> [task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin'
> '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
> [task 2018-06-27T16:51:11.828Z] ++ export
> PATH=/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/
> sbin:/usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++
> PATH=/builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/
> sbin:/usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin'
> '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
> [task 2018-06-27T16:51:11.828Z] ++ export
> PATH=/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/
> usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++
> PATH=/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/bin:/
> usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin'
> '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
> [task 2018-06-27T16:51:11.828Z] ++ export
> PATH=/builds/worker/workspace/rustc/bin:/builds/worker/workspace/gcc/bin:/
> builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/
> usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++
> PATH=/builds/worker/workspace/rustc/bin:/builds/worker/workspace/gcc/bin:/
> builds/worker/workspace/clang/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/
> usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++ for bin in '$TOOLTOOL_CHECKOUT/*/bin'
> '$TOOLTOOL_CHECKOUT/VC/bin/Hostx64/x86'
> [task 2018-06-27T16:51:11.828Z] ++ export
> PATH=/builds/worker/workspace/VC/bin/Hostx64/x86:/builds/worker/workspace/
> rustc/bin:/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/
> bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] ++
> PATH=/builds/worker/workspace/VC/bin/Hostx64/x86:/builds/worker/workspace/
> rustc/bin:/builds/worker/workspace/gcc/bin:/builds/worker/workspace/clang/
> bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> [task 2018-06-27T16:51:11.828Z] + mkdir -p /builds/worker/artifacts/
> [task 2018-06-27T16:51:11.829Z] + AUTOMATION=1
> [task 2018-06-27T16:51:11.829Z] + DIST=/builds/worker/artifacts/
> [task 2018-06-27T16:51:11.829Z] +
> /builds/worker/workspace/build/src/js/src/make-source-package.sh
> [task 2018-06-27T16:51:11.834Z] Environment:
> [task 2018-06-27T16:51:11.834Z]     MAKE = 
> [task 2018-06-27T16:51:11.834Z]     MKDIR = mkdir
> [task 2018-06-27T16:51:11.834Z]     TAR = tar
> [task 2018-06-27T16:51:11.834Z]     AUTOCONF = /usr/bin/autoconf2.13
> [task 2018-06-27T16:51:11.834Z]     STAGING = /tmp/mozjs-src-pkg
> [task 2018-06-27T16:51:11.834Z]     DIST = /builds/worker/artifacts/
> [task 2018-06-27T16:51:11.834Z]     SRCDIR =
> /builds/worker/workspace/build/src/js/src
> [task 2018-06-27T16:51:11.834Z]     MOZJS_NAME = mozjs
> [task 2018-06-27T16:51:11.834Z]     MOZJS_MAJOR_VERSION = 63
> [task 2018-06-27T16:51:11.834Z]     MOZJS_MINOR_VERSION = 0a1
> [task 2018-06-27T16:51:11.834Z]     MOZJS_PATCH_VERSION = 
> [task 2018-06-27T16:51:11.834Z]     MOZJS_ALPHA = 
> [task 2018-06-27T16:51:11.834Z] 
> [task 2018-06-27T16:51:11.834Z] Staging source tarball in
> /tmp/mozjs-src-pkg/mozjs-63.0a1.0...
> [task 2018-06-27T16:51:14.346Z] cp: cannot stat
> `/builds/worker/workspace/build/src/js/src/../../media/webrtc/trunk/tools/
> gyp': No such file or directory
> [taskcluster 2018-06-27 16:51:14.700Z] === Task Finished ===
> [taskcluster 2018-06-27 16:51:14.795Z] Unsuccessful task run with exit code:
> 1 completed in 196.859 seconds

Oh ok, that makes more sense!
Flags: needinfo?(nfroyd)
Flags: needinfo?(dminor)
It looks like we need a clobber in order for the build system to properly find
gyp at its new location.
Comment on attachment 8990790 [details]
Bug 1371485 - Moving gyp requires a clobber; r=chmanchester

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D2035
Attachment #8990790 - Flags: review+
Comment on attachment 8990788 [details]
Bug 1371485 - Update gyp path in make-source-package.sh; r=chmanchester

Chris Manchester (:chmanchester) has approved the revision.

https://phabricator.services.mozilla.com/D2034
Attachment #8990788 - Flags: review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fe01b4d86e1
Remove webrtc copy of gyp; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/a30385fdddc3
Remove unnecessary gyp files from webrtc; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/46707c66d441
Update gyp to 4d467626b0b9f59a85fb81ca4d7ea9eca99b9d8f; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/b94ed3379802
Use updated version of gyp; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/4828ebf3834b
Fix gflags root; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/3810cdc00441
Remove OS X find_sdk.py check; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/10a13ff35172
Update gyp path in make-source-package.sh; r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/acc0d8ae4c88
Moving gyp requires a clobber; r=chmanchester
You need to log in before you can comment on or make changes to this bug.