1371499 - Refactor url handling (deep-link, open-url, fxa-signin) code

Status: RESOLVED DUPLICATE of bug 1355636

(Firefox for iOS :: General, enhancement, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I'm not happy with how we now have three different things under the firefox:// scheme:

- firefox://fxa-signin?signin=<token>&someQuery=<data>...
- firefox://open-url?deep-link=https%253A...
- firefox://anything-here-does-not-matter?deeplink=https%253A...

This reflects in the code, which is handling the last two cases combined and seems all over the place. And the URL style for the last two is not enforced .. you can actually replace open-url with anything. This is not strict enough.

I would like to ask for three things:

- Introduce a firefox://deep-link?url= style url
- Enforce a firefox://open-url?url= style for the public API
- Refactor this code to have three clear separate blocks or functions to handle firefox://fxa-signin, firefox://open-url and firefox://deep-link.

Comment 1

[:sdaswani]

(In reply to Stefan Arentz [:st3fan] from comment #0)
> I'm not happy with how we now have three different things under the
> firefox:// scheme:
> 
> - firefox://fxa-signin?signin=<token>&someQuery=<data>...
> - firefox://open-url?deep-link=https%253A...
> - firefox://anything-here-does-not-matter?deeplink=https%253A...
> 
> This reflects in the code, which is handling the last two cases combined and
> seems all over the place. And the URL style for the last two is not enforced
> .. you can actually replace open-url with anything. This is not strict
> enough.
> 
> I would like to ask for three things:
> 
> - Introduce a firefox://deep-link?url= style url
> - Enforce a firefox://open-url?url= style for the public API
> - Refactor this code to have three clear separate blocks or functions to
> handle firefox://fxa-signin, firefox://open-url and firefox://deep-link.

Stefan to be clear, the following deep links would be available from external apps:
firefox://fxa-signin, firefox://open-url

The following deep links would not be available from external apps:
firefox://deep-link

??

Comment 2

[Vijay Budhram]

(In reply to Stefan Arentz [:st3fan] from comment #0)
> I'm not happy with how we now have three different things under the
> firefox:// scheme:
> 
> - firefox://fxa-signin?signin=<token>&someQuery=<data>...
> - firefox://open-url?deep-link=https%253A...
> - firefox://anything-here-does-not-matter?deeplink=https%253A...
> 
> This reflects in the code, which is handling the last two cases combined and
> seems all over the place. And the URL style for the last two is not enforced
> .. you can actually replace open-url with anything. This is not strict
> enough.
> 
> I would like to ask for three things:
> 
> - Introduce a firefox://deep-link?url= style url
> - Enforce a firefox://open-url?url= style for the public API
> - Refactor this code to have three clear separate blocks or functions to
> handle firefox://fxa-signin, firefox://open-url and firefox://deep-link.

Your proposal makes sense to me. Should this also handle existing deep linking capabilities? Currently, FxiOS in App Store can launch any url with firefox://?url=<url>.

Comment 3

[Bryan Munar (:bkmunar)]

Attachment: PR