Closed Bug 1371515 Opened 3 years ago Closed 3 years ago

Remove MDSM::IsShutdown()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

http://searchfox.org/mozilla-central/rev/a798ee4fc323f9387b7576dbed177859d29d09b7/dom/media/MediaDecoderStateMachine.cpp#3222-3225

It is bad for MDSM to handle events based on the current state which breaks the encapsulation. We already have ShutdownState to handle this case.
Assignee: nobody → jwwang
Depends on: 1371514
Priority: -- → P3
Attachment #8875986 - Flags: review?(kaku)
Comment on attachment 8875985 [details]
Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState.

https://reviewboard.mozilla.org/r/147388/#review151662
Attachment #8875985 - Flags: review?(kaku) → review+
Comment on attachment 8875986 [details]
Bug 1371515. P2 - remove the check from DecodeError().

https://reviewboard.mozilla.org/r/147390/#review151664
Attachment #8875986 - Flags: review?(kaku) → review+
Comment on attachment 8875987 [details]
Bug 1371515. P3 - remove IsShutdown() which now has no callers.

https://reviewboard.mozilla.org/r/147392/#review151660

::: commit-message-fadda:1
(Diff revision 1)
> +Bug 1371515. P3 - remove IsShutdown() which now has not callers. r?kaku

... has no callers ...
Attachment #8875987 - Flags: review?(kaku) → review+
Comment on attachment 8875988 [details]
Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all.

https://reviewboard.mozilla.org/r/147394/#review151666
Attachment #8875988 - Flags: review?(kaku) → review+
Comment on attachment 8875989 [details]
Bug 1371515. P5 - remove mIsShutdown which is not read at all.

https://reviewboard.mozilla.org/r/147396/#review151668
Attachment #8875989 - Flags: review?(kaku) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e10c8efbb0fe
P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/a12ce07a8154
P2 - remove the check from DecodeError(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/6266b3ba9d23
P3 - remove IsShutdown() which now has no callers. r=kaku
https://hg.mozilla.org/integration/autoland/rev/9a840c89892e
P4 - remove CanonicalIsShutdown() which has no callers at all. r=kaku
https://hg.mozilla.org/integration/autoland/rev/97877fd398ad
P5 - remove mIsShutdown which is not read at all. r=kaku
You need to log in before you can comment on or make changes to this bug.